-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging (Event Hubs, Service Bus) logging improvements #39904
Messaging (Event Hubs, Service Bus) logging improvements #39904
Conversation
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Liudmila, I don’t think with the changes so far we miss any logs that is crucial for incident investigations. Just some minor comments to hear your thoughts
...e/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/AmqpChannelProcessor.java
Show resolved
Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/MessageFlux.java
Outdated
Show resolved
Hide resolved
...azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorConnectionCache.java
Show resolved
Hide resolved
...core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorDispatcher.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java
Show resolved
Hide resolved
...e/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/AmqpChannelProcessor.java
Outdated
Show resolved
Hide resolved
cf49232
to
eb6fcfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, LGTM!
Fixes #39575
Removes some deprecated (a long time ago) internal, unused constructors.