fix the failed java unit test related to getBlob. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static void ThrowIfError(ClientResponse r) { | ||
| if (r.getStatus() >= 400) { | ||
| throw new UniformInterfaceException(r); | ||
| public static void ThrowIfNotSuccess(ClientResponse clientResponse) { |
There was a problem hiding this comment.
From grammatical point of view should this be ThrowIfNotSucceed or ThrowIfNotSucceeded. Also ThrowIfFailed would be good name candidate.
There was a problem hiding this comment.
Here the Success is Http Status code according to HTTP standard. Only if the status is 2xx, no exception would be thrown.
http://en.wikipedia.org/wiki/List_of_HTTP_status_codes
gcheng
pushed a commit
that referenced
this pull request
Apr 6, 2012
fix the failed java unit test related to getBlob.
joostdenijs
pushed a commit
to joostdenijs/azure-sdk-for-java
that referenced
this pull request
Jan 18, 2013
Refactor Job and Task into Crudy API, implementation of Action
joostdenijs
pushed a commit
to joostdenijs/azure-sdk-for-java
that referenced
this pull request
Jan 18, 2013
Renamed ...media.implementation.entities to ...media.entityoperations
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Apr 5, 2017
fix the failed java unit test related to getBlob.
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Apr 5, 2017
bug fix in CI machine.
lenala
pushed a commit
to lenala/azure-sdk-for-java
that referenced
this pull request
Nov 16, 2018
Fix bugs with message protection for keys create\delete
g2vinay
pushed a commit
to g2vinay/azure-sdk-for-java
that referenced
this pull request
Mar 4, 2019
Java Storage Client Library 2.1.0
g2vinay
pushed a commit
to g2vinay/azure-sdk-for-java
that referenced
this pull request
Mar 4, 2019
Share snapshot fix when getting server response
g2vinay
pushed a commit
to g2vinay/azure-sdk-for-java
that referenced
this pull request
May 30, 2019
Performance
navalev
pushed a commit
to navalev/azure-sdk-for-java
that referenced
this pull request
Dec 24, 2019
…ount search with result count tests
samvaity
added a commit
to samvaity/azure-sdk-for-java
that referenced
this pull request
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throw an exception if the HTTP status code is not success.