Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate ServiceBus Admin with source version of Autorest #40154

Merged
merged 2 commits into from
May 14, 2024
Merged

Regenerate ServiceBus Admin with source version of Autorest #40154

merged 2 commits into from
May 14, 2024

Conversation

alzimmermsft
Copy link
Member

Description

Regenerate ServiceBus Admin with a source build of Autorest that is fixing issues with polymorphic handling in XML stream-style serialization.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this May 14, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

srnagar
srnagar approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft merged commit 6a341f6 into Azure:main May 14, 2024
19 checks passed
@alzimmermsft alzimmermsft deleted the AzSB_FixXmlCodegenWorkingBranch branch May 14, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alzimmermsft @azure-sdk @srnagar