Add Testcontainers Service Connection support for Cosmos, Blob and Queue #40388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
azure-spring
|
Thank you for your contribution @eddumelendez! We will review the pull request and get back to you soon. |
2 tasks
|
API change check API changes are not detected in this pull request. |
rujche
approved these changes
Jun 12, 2024
rujche
reviewed
Jun 13, 2024
.../spring/cloud/autoconfigure/implementation/data/cosmos/CosmosDataAutoConfigurationTests.java
Show resolved
Hide resolved
...oud/autoconfigure/implementation/storage/blob/AzureStorageBlobResourceAutoConfiguration.java
Show resolved
Hide resolved
rujche
reviewed
Jun 13, 2024
.../cloud/autoconfigure/implementation/storage/blob/AzureStorageBlobAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
.../cloud/autoconfigure/implementation/storage/blob/AzureStorageBlobAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
rujche
reviewed
Jun 13, 2024
...loud/autoconfigure/implementation/storage/queue/AzureStorageQueueAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
|
FYI: About the test failure, I create a issue in spring-framework repo: spring-projects/spring-framework#33028 And for current PR, I'll fix this test failure by a workaround. |
…eBlobResourceAutoConfiguration.
|
Hi, @saragluna , could you please help to review this PR? |
|
Hi @rujche, thanks for taking care of the PR! Looking forward to see it integrated 😃 |
rujche
added a commit
to rujche/problem-reproduce
that referenced
this pull request
Jul 9, 2024
…atible with spring-boot 3.0.
…tible with spring-boot 3.0.
…bResourceAutoConfiguration, make code run-time compatible with spring-boot 3.0.
…e compatible with spring-boot 3.0.
|
Hi, @saragluna . |
|
Closing in favor of #41176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConnectionDetailsandService Connectionsupport have been added for Cosmos, Storage Blob and Storage Queue.Currently, Cosmos can be used with Testcontainers only using Gateway Mode. See testcontainers/testcontainers-java#5518
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
Fixes spring-projects/spring-boot#40329