POM Restructuring Phase #1 #8242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run java - appconfiguration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@JimSuplizio what are you thoughts on the side effects of this change. I know that some of the tooling that exists today depends on |
|
@weidongxu-microsoft what would be the implications if we removed the |
|
/azp run java - keyvault |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mitchdenny I think it is fine. I don't think mgmt SDK depends on these 2 hybrid builds. |
JimSuplizio
reviewed
Feb 18, 2020
|
/azp run java - core - ci |
|
Pull request contains merge conflicts. |
mitchdenny
force-pushed
the
remove-modules-from-parent
branch
from
674ba25
to
996cd58
Compare
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mitchdenny
force-pushed
the
remove-modules-from-parent
branch
from
3c54907
to
31fe55b
Compare
mitchdenny
force-pushed
the
remove-modules-from-parent
branch
from
62abb34
to
42aeeb3
Compare
joshfree
reviewed
Mar 19, 2020
joshfree
approved these changes
Mar 19, 2020
|
/azp run java - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in a number of changes designed to restructure the relationship between our builds and parent POMs. Before this PR our parent POMs functioned as aggregators for developers who wanted to build the whole tree, we then had seperate
pom.service.xmlfiles that the pipelines used.This change repurposes
pom.xmlin the root of the repo and makes it a true top level aggregate for the entire repo (aside from management plane, but we'll get to that). All of our track 1 and track 2 modules are referenced in the aggregate and you use the-pland-amswitches.Our pipelines have been reconfigured to use this root aggregate and we generate the
-plswitch based on the artifact list in theci.ymlfile.One of the benefits we picked up was that we no longer need to do the seperate install of
sdk-build-toolsbecause it is in the graph, so anything that depends on it will end up triggering it to build.