[engsys] remove unused dependency url (#24380)

* [engsys] remove unused dependency `url` Related: #24379 * Replace usage of `url` with now globally available `URL` * The negative LRO tests have been updated to have proper key identifier format. Previously `url` is more forgiving on invalid urls.
Azure · Jan 6, 2023 · 95705cb · 95705cb
1 parent 53ae86d
commit 95705cb
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 28 deletions.
diff --git a/sdk/core/core-amqp/package.json b/sdk/core/core-amqp/package.json
@@ -82,7 +82,6 @@
     "rhea": "^2.0.3",
     "rhea-promise": "^2.1.0",
     "tslib": "^2.2.0",
-    "url": "^0.11.0",
     "util": "^0.12.1"
   },
   "devDependencies": {

diff --git a/sdk/keyvault/keyvault-certificates/package.json b/sdk/keyvault/keyvault-certificates/package.json
@@ -154,7 +154,6 @@
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
     "source-map-support": "^0.5.9",
-    "typescript": "~4.8.0",
-    "url": "^0.11.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/keyvault/keyvault-certificates/test/internal/lroUnexpectedErrors.spec.ts b/sdk/keyvault/keyvault-certificates/test/internal/lroUnexpectedErrors.spec.ts
@@ -17,7 +17,7 @@ describe("The LROs properly throw on unexpected errors", () => {
       const client: any = {
         async deleteCertificate(): Promise<any> {
           return {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
         },
@@ -41,7 +41,7 @@ describe("The LROs properly throw on unexpected errors", () => {
       const client: any = {
         async deleteCertificate(): Promise<any> {
           return {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
         },
@@ -67,7 +67,7 @@ describe("The LROs properly throw on unexpected errors", () => {
         const client: any = {
           async deleteCertificate(): Promise<any> {
             return {
-              id: "/version/name/version",
+              id: "https://keyvaultname.vault.azure.net/version/name/version",
               recoveryId: "something",
             };
           },
@@ -108,7 +108,7 @@ describe("The LROs properly throw on unexpected errors", () => {
             requestId: "something",
           };
           const body = {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
           const response: FullOperationResponse = {
@@ -153,7 +153,7 @@ describe("The LROs properly throw on unexpected errors", () => {
             requestId: "something",
           };
           const body = {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
           const response: FullOperationResponse = {
@@ -199,7 +199,7 @@ describe("The LROs properly throw on unexpected errors", () => {
               requestId: "something",
             };
             const body = {
-              id: "/version/name/version",
+              id: "https://keyvaultname.vault.azure.net/version/name/version",
               recoveryId: "something",
             };
             const response: FullOperationResponse = {

diff --git a/sdk/keyvault/keyvault-common/src/parseKeyVaultIdentifier.ts b/sdk/keyvault/keyvault-common/src/parseKeyVaultIdentifier.ts
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import * as url from "url";
-
 /**
  * The parsed components of a Key Vault entity identifier.
  */
@@ -41,7 +39,7 @@ export function parseKeyVaultIdentifier(
 
   let baseUri;
   try {
-    baseUri = url.parse(identifier, true, true);
+    baseUri = new URL(identifier);
   } catch (e: any) {
     throw new Error(`Invalid ${collection} identifier: ${identifier}. Not a valid URI`);
   }

diff --git a/sdk/keyvault/keyvault-keys/package.json b/sdk/keyvault/keyvault-keys/package.json
@@ -152,7 +152,6 @@
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
     "source-map-support": "^0.5.9",
-    "typescript": "~4.8.0",
-    "url": "^0.11.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/keyvault/keyvault-keys/test/internal/lroUnexpectedErrors.spec.ts b/sdk/keyvault/keyvault-keys/test/internal/lroUnexpectedErrors.spec.ts
@@ -16,7 +16,7 @@ describe("The LROs properly throw on unexpected errors", () => {
         async deleteKey(): Promise<any> {
           return {
             key: {
-              kid: "/version/name/version",
+              kid: "https://keyVaultName.vault.azure.net/version/name/version",
             },
             recoveryId: "something",
           };
@@ -42,7 +42,7 @@ describe("The LROs properly throw on unexpected errors", () => {
         async deleteKey(): Promise<any> {
           return {
             key: {
-              kid: "/version/name/version",
+              kid: "https://keyVaultName.vault.azure.net/version/name/version",
             },
             recoveryId: "something",
           };
@@ -70,7 +70,7 @@ describe("The LROs properly throw on unexpected errors", () => {
           async deleteKey(): Promise<any> {
             return {
               key: {
-                kid: "/version/name/version",
+                kid: "https://keyVaultName.vault.azure.net/version/name/version",
               },
               recoveryId: "something",
             };
@@ -104,7 +104,7 @@ describe("The LROs properly throw on unexpected errors", () => {
         async recoverDeletedKey(): Promise<any> {
           return {
             key: {
-              kid: "/version/name/version",
+              kid: "https://keyVaultName.vault.azure.net/version/name/version",
             },
             recoveryId: "something",
           };
@@ -130,7 +130,7 @@ describe("The LROs properly throw on unexpected errors", () => {
         async recoverDeletedKey(): Promise<any> {
           return {
             key: {
-              kid: "/version/name/version",
+              kid: "https://keyVaultName.vault.azure.net/version/name/version",
             },
             recoveryId: "something",
           };
@@ -158,7 +158,7 @@ describe("The LROs properly throw on unexpected errors", () => {
           async recoverDeletedKey(): Promise<any> {
             return {
               key: {
-                kid: "/version/name/version",
+                kid: "https://keyVaultName.vault.azure.net/version/name/version",
               },
               recoveryId: "something",
             };

diff --git a/sdk/keyvault/keyvault-secrets/package.json b/sdk/keyvault/keyvault-secrets/package.json
@@ -147,7 +147,6 @@
     "rimraf": "^3.0.0",
     "sinon": "^9.0.2",
     "source-map-support": "^0.5.9",
-    "typescript": "~4.8.0",
-    "url": "^0.11.0"
+    "typescript": "~4.8.0"
   }
 }
diff --git a/sdk/keyvault/keyvault-secrets/test/internal/lroUnexpectedErrors.spec.ts b/sdk/keyvault/keyvault-secrets/test/internal/lroUnexpectedErrors.spec.ts
@@ -15,7 +15,7 @@ describe("The LROs properly throw on unexpected errors", () => {
       const client: any = {
         async deleteSecret(): Promise<any> {
           return {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
         },
@@ -39,7 +39,7 @@ describe("The LROs properly throw on unexpected errors", () => {
       const client: any = {
         async deleteSecret(): Promise<any> {
           return {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
         },
@@ -65,7 +65,7 @@ describe("The LROs properly throw on unexpected errors", () => {
         const client: any = {
           async deleteSecret(): Promise<any> {
             return {
-              id: "/version/name/version",
+              id: "https://keyvaultname.vault.azure.net/version/name/version",
               recoveryId: "something",
             };
           },
@@ -97,7 +97,7 @@ describe("The LROs properly throw on unexpected errors", () => {
       const client: any = {
         async recoverDeletedSecret(): Promise<any> {
           return {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
         },
@@ -121,7 +121,7 @@ describe("The LROs properly throw on unexpected errors", () => {
       const client: any = {
         async recoverDeletedSecret(): Promise<any> {
           return {
-            id: "/version/name/version",
+            id: "https://keyvaultname.vault.azure.net/version/name/version",
             recoveryId: "something",
           };
         },
@@ -147,7 +147,7 @@ describe("The LROs properly throw on unexpected errors", () => {
         const client: any = {
           async recoverDeletedSecret(): Promise<any> {
             return {
-              id: "/version/name/version",
+              id: "https://keyvaultname.vault.azure.net/version/name/version",
               recoveryId: "something",
             };
           },