Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Monitor Query Readme Issue #29522

Closed
v-weiyding opened this issue Apr 30, 2024 · 1 comment · Fixed by #29819
Closed

Azure Monitor Query Readme Issue #29522

v-weiyding opened this issue Apr 30, 2024 · 1 comment · Fixed by #29819
Assignees
@sarangan12
Labels
Client This issue points to a problem in the data-plane of the library. Docs Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team. test-manual-pass

Comments

@v-weiyding
Copy link
Member

Section link1
image

link2,link3
image
image

link4
image

Reason:

  1. Missing comma.
  2. Variable names are inconsistent
  3. String format error.

Suggestion:

  1. Add a comma.
  2. Keep variable names consistent.
  3. Use backquotes.

@joheredi, @lmolkova for notification.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team. labels Apr 30, 2024
@github-actions GitHub Actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @AzmonActionG @azmonALERTS @AzMonEssential @AzmonLogA @dadunl @sameergMS.

@v-xuto v-xuto added Docs needs-team-triage This issue needs the team to triage. test-manual-pass labels May 6, 2024
@xirzec xirzec removed the needs-team-triage This issue needs the team to triage. label May 6, 2024
@v-jiaodi v-jiaodi mentioned this issue May 27, 2024
Merged
qiaozha pushed a commit that referenced this issue May 29, 2024
@v-jiaodi @kazrael2119
Fix Azure Monitor Query Readme (#29819)
4ae1327 
fixes #29522 

@joheredi, @lmolkova and @sarangan12 for notification.

---------

Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarangan12 sarangan12

Labels
Client This issue points to a problem in the data-plane of the library. Docs Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team. test-manual-pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Azure Monitor Query Readme v-jiaodi/azure-sdk-for-js
4 participants
@sarangan12 @xirzec @v-xuto @v-weiyding