Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-http] defaultHttpClient test failure after auto updates of fetch-mock to v8.3.0 #6714

Closed
jeremymeng opened this issue Dec 30, 2019 · 0 comments · Fixed by #7131
Closed

[core-http] defaultHttpClient test failure after auto updates of fetch-mock to v8.3.0 #6714

jeremymeng opened this issue Dec 30, 2019 · 0 comments · Fixed by #7131
Assignees
@jeremymeng
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] February

Comments

@jeremymeng
Copy link
Contributor

We need to investigate whether it's a fetch-mock regression or whether we need to update our tests.
All failures have error messages like

Error: fetch-mock: Adding route with same name or matcher as existing route. See `overwriteRoutes` option.
    at Object.FetchMock.addRoute (/Users/runner/runners/2.163.1/work/1/s/common/temp/node_modules/.pnpm/registry.npmjs.org/fetch-mock/8.3.0_node-fetch@2.6.0/node_modules/fetch-mock/cjs/lib/set-up-and-tear-down.js:41:9)
    at Object.FetchMock.mock (/Users/runner/runners/2.163.1/work/1/s/common/temp/node_modules/.pnpm/registry.npmjs.org/fetch-mock/8.3.0_node-fetch@2.6.0/node_modules/fetch-mock/cjs/lib/set-up-and-tear-down.js:6:8)
    at FetchHttpMock.mockHttpMethod (test/mockHttp.ts:2:35)
    at FetchHttpMock.post (test/mockHttp.ts:2:35)
    at Context.<anonymous> (test/defaultHttpClientTests.ts:4:2172)
    at step (/Users/runner/runners/2.163.1/work/1/s/common/temp/node_modules/.pnpm/registry.npmjs.org/tslib/1.10.0/node_modules/tslib/tslib.js:136:27)
    at Object.next (/Users/runner/runners/2.163.1/work/1/s/common/temp/node_modules/.pnpm/registry.npmjs.org/tslib/1.10.0/node_modules/tslib/tslib.js:117:57)
    at /Users/runner/runners/2.163.1/work/1/s/common/temp/node_modules/.pnpm/registry.npmjs.org/tslib/1.10.0/node_modules/tslib/tslib.js:110:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/Users/runner/runners/2.163.1/work/1/s/common/temp/node_modules/.pnpm/registry.npmjs.org/tslib/1.10.0/node_modules/tslib/tslib.js:106:16)
    at Context.<anonymous> (test/defaultHttpClientTests.ts:4:1805)
    at processImmediate (internal/timers.js:439:21)
@jeremymeng jeremymeng added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Dec 30, 2019
@jeremymeng jeremymeng mentioned this issue Dec 30, 2019
Merged
@ramya-rao-a ramya-rao-a added this to the [2020] February milestone Dec 31, 2019
@jeremymeng jeremymeng self-assigned this Jan 28, 2020
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this issue Jan 28, 2020
@jeremymeng
[core-http][test] revert workaround of pinning fetch-mock version
a5f202f 
Resolves Azure#6714

There was a regression in fetch-mock

wheresrhys/fetch-mock#493

which is already fixed in the latest version of fetch-mock.
@jeremymeng jeremymeng mentioned this issue Jan 28, 2020
Merged
jeremymeng added a commit that referenced this issue Jan 28, 2020
@jeremymeng
[core-http][test] revert workaround of pinning fetch-mock version (#7131
a08bd51 
)

* [core-http][test] revert workaround of pinning fetch-mock version

Resolves #6714

There was a regression in fetch-mock

wheresrhys/fetch-mock#493

which is already fixed in the latest version of fetch-mock.

* Update pnpm-lock.yaml
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] February
Development

Successfully merging a pull request may close this issue.

[core-http][test] revert workaround of pinning fetch-mock version jeremymeng/azure-sdk-for-js
2 participants
@jeremymeng @ramya-rao-a