Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev dependency "rollup" #9348

Closed
mikeharder opened this issue Jun 5, 2020 · 5 comments
Closed

Update dev dependency "rollup" #9348

mikeharder opened this issue Jun 5, 2020 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@mikeharder
Copy link
Member

Our repo is currently using rollup@1.32.1. A new major version rollup@2.0.0 was released on 3/6/2020. The upgrade may require significant changes.

https://github.com/rollup/rollup/blob/master/CHANGELOG.md#200

@mikeharder mikeharder added the Client This issue points to a problem in the data-plane of the library. label Jun 5, 2020
@mikeharder mikeharder added needs-triage This is a new issue that needs to be triaged to the appropriate team. and removed Client This issue points to a problem in the data-plane of the library. labels Jun 9, 2020
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jul 20, 2020
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 20, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jul 20, 2020
@willmtemple
Copy link
Contributor

(CC @bterlson for discussing Node 8 support)

Major blocker here is

Rollup now requires at least Node 10 to run, or a sufficiently modern browser (#3346)

In order to make the migration to Rollup 2 we'd need to move the Linux pipeline build off of Node 8. Nothing else in the changelog really sticks out at me, but there's always a chance there would be other complications too.

@mikeharder @praveenkuttappan One thing that could work here is if we could do all the builds in CI with Node 12 and then only do test runs with our different node versions. Is this something we can do easily or is everything in the pipeline run with the same base node configuration.

@mikeharder
Copy link
Member Author

@mikeharder @praveenkuttappan One thing that could work here is if we could do all the builds in CI with Node 12 and then only do test runs with our different node versions. Is this something we can do easily or is everything in the pipeline run with the same base node configuration.

This is already done: #8804

@ramya-rao-a ramya-rao-a modified the milestones: Backlog, MQ-2020 Nov 16, 2020
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, [2021] February Dec 23, 2020
@witemple-msft witemple-msft self-assigned this Jan 6, 2021
@witemple-msft
Copy link
Member

Currently blocked on an upstream bug in @rollup/plugin-commonjs: rollup/plugins#743

Migrating to rollup 2 and the newer versions of plugin-commonjs will ease the transition to the shared rollup configuration, so this is related to that as well.

@witemple-msft witemple-msft modified the milestones: [2021] May, [2021] June Apr 15, 2021
@ramya-rao-a ramya-rao-a modified the milestones: [2021] June, Backlog Jun 17, 2021
@ramya-rao-a ramya-rao-a added the EngSys This issue is impacting the engineering system. label Jun 17, 2021
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2021] December Jul 26, 2021
@maorleger
Copy link
Member

Spoke to @witemple-msft - he's looking into this so he OK'd assigning it to him for now

@maorleger maorleger modified the milestones: Backlog, [2022] January Dec 13, 2021
@maorleger maorleger assigned witemple-msft and unassigned maorleger Dec 13, 2021
@jeremymeng
Copy link
Contributor

closing in favor of bot-auto-created #19235.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

6 participants