New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-http] Find additionalProperties in referenced mapper #11473
Merged
joheredi
merged 2 commits into
Azure:master
from
joheredi:core-http-additional-properties
Sep 25, 2020
Merged
[core-http] Find additionalProperties in referenced mapper #11473
joheredi
merged 2 commits into
Azure:master
from
joheredi:core-http-additional-properties
Sep 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
requested review from
bterlson,
chradek,
daviwil and
ramya-rao-a
as code owners
September 24, 2020 18:57
ghost
added
the
Azure.Core
label
Sep 24, 2020
xirzec
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good! Thanks for adding test coverage too! 👍
bterlson
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
markwolff
pushed a commit
to markwolff/azure-rest-api-specs
that referenced
this pull request
Sep 24, 2020
Related to Azure/azure-sdk-for-js#11473 The JS exporter requires additional polymorphism hints to completely serialize `baseData`. For now, `additionalProperties` should be passed until something like `oneOf` becomes available.
markwolff
added a commit
to Azure/azure-rest-api-specs
that referenced
this pull request
Sep 24, 2020
Related to Azure/azure-sdk-for-js#11473 The JS exporter requires additional polymorphism hints to completely serialize `baseData`. For now, `additionalProperties` should be passed until something like `oneOf` becomes available.
10 tasks
markwolff
approved these changes
Sep 24, 2020
deyaaeldeen
pushed a commit
to deyaaeldeen/azure-sdk-for-js
that referenced
this pull request
Sep 25, 2020
* Look for additional properties in referenced mapper * Format
lmazuel
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this pull request
Oct 5, 2020
Related to Azure/azure-sdk-for-js#11473 The JS exporter requires additional polymorphism hints to completely serialize `baseData`. For now, `additionalProperties` should be passed until something like `oneOf` becomes available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing object using mappers with references to other mappers, core-http doesn't look at the referenced mapper for
additionalProperties
it only looks for it in the source mapper.Sample of a referenced mapper:
This PR modifies the serializer and deserializer so that they also look at the referenced mapper for
additionalProperties
and ports the changes tocore-client