[core-http] Redirect pipeline #11863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
requested review from
bterlson,
chradek,
daviwil,
jeremymeng and
ramya-rao-a
as code owners
ghost
added
the
xirzec
approved these changes
Oct 15, 2020
|
Hello @joheredi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
sarangan12
approved these changes
Oct 15, 2020
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core-httphas been using fetch without explicitly specifying a redirect behavior which defaults tofollow. This caused ourredirectPipelineto never actually execute.In this PR I'm setting redirect to
manualso that our pipeline handles redirects. Unfortunately there doesn't seem to be a way to set manual redirect handling forXMLHttpRequest, so browsers will keep the default behavior.I'm also fixing the redirect logic to align with the tests in Autorest Test Server and be consistent with the other languages
Fixes #10103