[ServiceBus] Helper function to parse connection string #11949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
bterlson,
chradek,
HarshaNalluru,
richardpark-msft and
xirzec
as code owners
ghost
added
the
sdk/servicebus/service-bus/test/internal/connectionString.spec.ts
Outdated
Show resolved
Hide resolved
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| export function parseServiceBusConnectionString( | ||
| connectionString: string | ||
| ): ServiceBusConnectionStringProperties { | ||
| const parsedResult = parseConnectionString<{ |
There was a problem hiding this comment.
Nice! It's good to see that you preserve camelCasing ;)
| } | ||
|
|
||
| const output: ServiceBusConnectionStringProperties = { | ||
| fullyQualifiedNamespace: (parsedResult.Endpoint.match(".*://([^/]*)") || [])[1], |
There was a problem hiding this comment.
I feel like a line could not get more Javascript-y than this :)
| @@ -316,7 +318,7 @@ describe("Atom management - Authentication", function(): void { | |||
| ); | |||
| should.equal( | |||
| (await serviceBusAdministrationClient.getNamespaceProperties()).name, | |||
| host.match("(.*).servicebus.windows.net")[1], | |||
| (host.match("(.*).servicebus.windows.net") || [])[1], | |||
There was a problem hiding this comment.
Is this going to work when we get to the "private" clouds?
There was a problem hiding this comment.
No, it wont. But since our tests do not run in private clouds, we should be good. We should make sure we dont do this in any of our library code though
| it("Extracts Service Bus properties with Endpoint & SharedKey", () => { | ||
| const connectionString = `Endpoint=${expectedEndpoint};SharedAccessKey=${expectedSharedKey};SharedAccessKeyName=${expectedSharedKeyName}`; | ||
| const connectionStringProperties = parseServiceBusConnectionString(connectionString); | ||
| assert.equal(connectionStringProperties.endpoint, expectedEndpoint); |
There was a problem hiding this comment.
Not a change you have to make.
I've been doing assert.deepEqual({ object }, expected) - it has nice output when the assertion fails and you get to see all the fields, not just the one that failed to match. Can be helpful sometimes if you're trying to figure out how badly you "missed" the right answer.
| // const tokenProvider = new TestTokenCredential(); | ||
| // receiver = new ServiceBusReceiverClient( | ||
| // { | ||
| // host: connectionObject.Endpoint.substr(5), | ||
| // host: connectionObject.endpoint.substr(5), |
There was a problem hiding this comment.
Your thoroughness knows no bounds. :)
richardpark-msft
approved these changes
Oct 21, 2020
HarshaNalluru
approved these changes
Oct 21, 2020
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
This was referenced Oct 21, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 10, 2020
Update DeploymentScripts swagger to address swagger correctness issues (Azure#11949)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 10, 2020
Update DeploymentScripts swagger to address swagger correctness issues (Azure#11949)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 10, 2020
Update DeploymentScripts swagger to address swagger correctness issues (Azure#11949)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 10, 2020
Update DeploymentScripts swagger to address swagger correctness issues (Azure#11949)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 10, 2020
Update DeploymentScripts swagger to address swagger correctness issues (Azure#11949)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 10, 2020
Update DeploymentScripts swagger to address swagger correctness issues (Azure#11949)
maorleger
added a commit
that referenced
this pull request
Jan 28, 2021
## What Add the following to the Event Hubs package: - A helper methods `parseEventHubConnectionString` that validates and parses a given connection string - An interface `EventHubConnectionStringProperties` that defines the output of the above method. ## Why In a [recent PR](#11949) the same change has been made for ServiceBus to provide a parsing utility that can help transform a raw connection string for use with credential-based client creation. Implements #11894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the below to the Service Bus package to satisfy the requirements listed in #11893
parseServiceBusConnectionStringthat validates and parses the given connection stringServiceBusConnectionStringPropertiesthat defines the output of the above methodThis has not been added to
@azure/core-amqpintentionally. The core package already has a generic parseConnectionString() method which has limitations when compared to the requirements we have (see #11909 for details).