Fix UTF-8 String len & DELETE Request Body #15314
Conversation
sarangan12
requested review from
bterlson,
chradek,
deyaaeldeen and
jeremymeng
as code owners
| @@ -300,7 +300,7 @@ function streamToText(stream: NodeJS.ReadableStream): Promise<string> { | |||
| }); | |||
| } | |||
|
|
|||
| function getBodyLength(body: RequestBodyType): number | null { | |||
| export function getBodyLength(body: RequestBodyType): number | null { | |||
There was a problem hiding this comment.
if we export I think we have to mark it as internal in a doc comment to avoid the documentation system picking it up, right @deyaaeldeen ?
There was a problem hiding this comment.
Added the @internal tag to the method
|
|
||
| it("Gets the length of the non-ASCII string correctly", function() { | ||
| const str: string = | ||
| "啊齄丂狛狜隣郎隣兀﨩ˊ〞〡￤℡㈱‐ー﹡﹢﹫、〓ⅰⅹ⒈€㈠㈩ⅠⅫ！￣ぁんァヶΑ︴АЯаяāɡㄅㄩ─╋︵﹄︻︱︳︴ⅰⅹɑɡ〇〾⿻⺁䜣€"; |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/check-enforcer reset |
2 similar comments
|
/check-enforcer reset |
|
/check-enforcer reset |
|
/check-enforcer evaluate |
|
/check-enforcer override |
Track2 modify sql readme.go.md (Azure#15314) * servicebus readme.go.md * track2 modify sql readme.go.md
This PR is to fix the issues reported at:
@xirzec Please review and approve the PR.
@ramya-rao-a FYI.....