[Core] - Update readme, fix test paths, and remove OpenCensus wrappers #15770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
bterlson,
chradek,
danieljurek,
mikeharder,
mitchdenny,
praveenkuttappan,
richardpark-msft,
weshaggard and
xirzec
as code owners
ghost
added
the
maorleger
commented
Jun 16, 2021
| // https://github.com/karma-runner/karma-chrome-launcher | ||
| process.env.CHROME_BIN = require("puppeteer").executablePath(); | ||
|
|
||
| module.exports = function(config) { |
There was a problem hiding this comment.
I didn't bother too much, or at all, with karma.conf.js. I just took what is in core-rest-client as is.
xirzec
approved these changes
Jun 16, 2021
richardpark-msft
approved these changes
Jun 16, 2021
| "strictEqual", | ||
| "notDeepEqual", | ||
| "notStrictEqual", | ||
| "notDeepStrictEqual" |
There was a problem hiding this comment.
Ha, you add one more item to the list and it blows up the formatting..
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jun 21, 2021
Azure#15770) ## What - Add missing headers to Core Tracing README - Remove OpenCensus Wrappers - Fix dist paths - Enable browser tests ## Why - Ensures that our package README conforms to guidelines so we can remove the exception for core-tracing - My understanding is that OpenTelemetry was compatible with OpenCensus but has since drifted far enough that direct mappings are no longer possible. The other two I noticed in passing - when running tests after switching branches I saw old test code run that no longer exists. When I looked into it, I noticed that we were still generating into `test-dist` but changed our commands to expect `dist-test`. This led me down a little rabbit hole of looking at our rollup configs so I decided to just go ahead and clean this up wholesale - adding browser tests, fixing all the paths, etc. Resolves Azure#15732 Resolves Azure#14725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
The other two I noticed in passing - when running tests after switching branches I saw old test code run that no longer exists.
When I looked into it, I noticed that we were still generating into
test-distbut changed our commands to expectdist-test.This led me down a little rabbit hole of looking at our rollup configs so I decided to just go ahead and clean this up wholesale -
adding browser tests, fixing all the paths, etc.
Resolves #15732
Resolves #14725