New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changefeed all versions and deletes mode #28161
Merged
sajeetharan
merged 19 commits into
Azure:main
from
amanrao23:changefeed-allVersionsAndDeletesMode
Apr 23, 2024
Merged
Changefeed all versions and deletes mode #28161
sajeetharan
merged 19 commits into
Azure:main
from
amanrao23:changefeed-allVersionsAndDeletesMode
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check APIView has identified API level changes in this PR and created following API reviews. |
amanrao23
requested review from
bterlson,
xirzec,
jeremymeng,
kushagraThapar,
kirankumarkolli,
abkolant-MSFT,
simorenoh and
v1k1
as code owners
January 5, 2024 06:10
topshot99
reviewed
Jan 23, 2024
topshot99
reviewed
Jan 23, 2024
topshot99
reviewed
Jan 23, 2024
topshot99
reviewed
Jan 23, 2024
sdk/cosmosdb/cosmos/test/public/integration/changeFeedIterator.spec.ts
Outdated
Show resolved
Hide resolved
topshot99
reviewed
Jan 23, 2024
sdk/cosmosdb/cosmos/test/public/integration/changeFeedIterator.spec.ts
Outdated
Show resolved
Hide resolved
topshot99
reviewed
Jan 23, 2024
sdk/cosmosdb/cosmos/src/client/ChangeFeed/ChangeFeedRetentionTimeSpan.ts
Show resolved
Hide resolved
sdk/cosmosdb/cosmos/src/client/ChangeFeed/ChangeFeedRetentionTimeSpan.ts
Outdated
Show resolved
Hide resolved
amanrao23
requested review from
weshaggard,
benbp,
mpodwysocki,
quentinRobinson,
joheredi,
AikoBB,
maximrytych-ms,
mjafferi-msft,
marche0133,
yogeshmo,
LuChen-Microsoft,
danielav7,
akania,
jingjlii,
wanghoppe,
dpwatrous,
NickKouds,
LarryOsterman,
anilba06,
gkostal,
HarshaNalluru and
minhanh-phan
as code owners
April 22, 2024 10:45
amanrao23
force-pushed
the
changefeed-allVersionsAndDeletesMode
branch
from
April 22, 2024 10:56
0d2a034
to
8b9056c
Compare
philipthomas-MSFT
approved these changes
Apr 22, 2024
sajeetharan
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
#27058
Describe the problem that is addressed by this PR
Currently Cosmos DB JS SDK does not support allVersionsAndDeletes Mode in change feed. This PR adds support for that.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists