Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notification-hubs] Fix FCMV1 bugs #29507

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[notification-hubs] Fix FCMV1 bugs #29507

merged 1 commit into from
Apr 29, 2024

Conversation

mpodwysocki
Copy link
Contributor

Packages impacted by this PR

  • @azure/notification-hubs

Issues associated with this PR

Describe the problem that is addressed by this PR

Fixes the right signatures for the FCM versus FCM Legacy.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/notification-hubs

@mpodwysocki mpodwysocki merged commit e905eaf into main Apr 29, 2024
22 checks passed
@mpodwysocki mpodwysocki deleted the bug/29465 branch April 29, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants