Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-utils] Update to 2.0 #29573

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

[test-utils] Update to 2.0 #29573

wants to merge 30 commits into from
+702 −1,227

Conversation

mpodwysocki
Copy link
Contributor

Packages impacted by this PR

  • @azure-tools/test-utils

Issues associated with this PR

Describe the problem that is addressed by this PR

Migrate the @azure-tools/test-utils to vitest and ESM.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added the test-utils Label for the issues related to the @azure/test-utils package label May 3, 2024
xirzec
xirzec reviewed May 3, 2024
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right direction, just some nits about how we augment the assertion helpers

sdk/test-utils/test-utils/src/chaiAzure.ts Outdated Show resolved Hide resolved
maorleger
maorleger approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sdk/test-utils/test-utils/src/tracing/azureTraceMatcher.ts Show resolved Hide resolved
sdk/test-utils/test-utils/src/tracing/testSpan.ts Show resolved Hide resolved
@mpodwysocki mpodwysocki enabled auto-merge (squash) May 8, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec left review comments

@maorleger maorleger maorleger approved these changes

@HarshaNalluru HarshaNalluru HarshaNalluru approved these changes

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@timovv timovv Awaiting requested review from timovv timovv is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

Assignees
No one assigned
Labels
test-utils Label for the issues related to the @azure/test-utils package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mpodwysocki @xirzec @maorleger @HarshaNalluru