Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Priority queue extraction #29584

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Priority queue extraction #29584

wants to merge 29 commits into from

Conversation

topshot99
Copy link
Contributor

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

topshot99 and others added 14 commits May 1, 2024 17:15
@topshot99 @mkhandelwal-123
Feature/ru capping+vector search (Azure#29547)
b5c3e4f 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@amanrao23
Add NonStreamingOrderBy in supporting features
3ea85cb
@amanrao23
Add NonStreaming queries in pipelineExecutionContext
4f5a8d8
@amanrao23
format
4d557c6
@mkhandelwal-123
add non streaming orderby component
8afea30
@mkhandelwal-123
add test
d2eeae9
@mkhandelwal-123
update format
f827753
@topshot99 @mkhandelwal-123
Feature/cosmosdb/ru cap + vector search (Azure#29570)
edb3467 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@amanrao23
Add distinctNonStreamingOrderBy endpoint
de3654d
@amanrao23
add fetchMore implementation for nonStreamingOrderby
e56b02c
@amanrao23
Update NonStreamingOrderByResult and Response
cb2d288
@mkhandelwal-123
resolve conflicts
5daeb42
@mkhandelwal-123
Merge branch 'feature/cosmosdb/RU-Cap-+-Vector-Search' of github.com:…
e37533e 
…Azure/azure-sdk-for-js into feature/cosmosdb/RU-Cap-+-Vector-Search
@mkhandelwal-123
extract priority queue implementation
ce50f03
@github-actions github-actions bot added the Cosmos label May 5, 2024
topshot99 and others added 6 commits May 5, 2024 10:24
@topshot99 @mkhandelwal-123
Feature/cosmosdb/ru cap + vector search (Azure#29585)
8dcd3d9 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@mkhandelwal-123
add priority queue tests
fdaefc4
@amanrao23
fix orderByComparator and pq
2ae1058
@amanrao23
use orderbyComparator and pq
762d491
@amanrao23
Add comments and fix payload of result
c86e31c
@amanrao23
update fetchAll to ignore empty nonStreaming Results
f49d844
mkhandelwal-123 and others added 9 commits May 6, 2024 14:31
@mkhandelwal-123
update order by comparator logic
c0be82a
@mkhandelwal-123
resolve conflict
b5b56bd
@mkhandelwal-123
add test
f81ecd6
@topshot99 @mkhandelwal-123
Feature/cosmosdb/ru cap + vector search (Azure#29587)
8d4fcc5 
### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
@mkhandelwal-123
add support for offset and limit
62f4a25
@mkhandelwal-123
update unit test
d1a2ef9
@mkhandelwal-123
update element addition to buffer
54ba7f3
@mkhandelwal-123
resolve conflicts
bb5558f
@mkhandelwal-123
update api.md file
ddc295f
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/cosmos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar kushagraThapar is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@simorenoh simorenoh Awaiting requested review from simorenoh simorenoh is a code owner

@v1k1 v1k1 Awaiting requested review from v1k1 v1k1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@topshot99 @azure-sdk @amanrao23 @mkhandelwal-123