[Search] Fix test resource deployment #29599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
3 times, most recently
from
79ded77
to
94cabd6
Compare
|
/azp run js - search - tests |
|
No pipelines are associated with this pull request. |
|
/azp run js - search-documents - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
from
94cabd6
to
9cfc489
Compare
|
/azp run js - search-documents - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
from
9cfc489
to
2673a9f
Compare
|
/azp run js - search-documents - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
from
2673a9f
to
186d9ee
Compare
maorleger
approved these changes
May 7, 2024
| @@ -0,0 +1,8 @@ | |||
| using './test-resources.bicep' | |||
There was a problem hiding this comment.
woah I have not seen this bicepparam file yet - what is it used for?
There was a problem hiding this comment.
I was having trouble using the New-TestResources.ps1 script, so this file is a template for contributors to use to deploy test resources.
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
from
186d9ee
to
9c42f32
Compare
This was referenced May 8, 2024
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
from
9c42f32
to
42b37dc
Compare
1 task
|
/azp run js - search-documents - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
2 times, most recently
from
9d10c29
to
225f363
Compare
|
/azp run js - search-documents - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
from
225f363
to
5b99c25
Compare
|
/azp run js - search-documents - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgetu
force-pushed
the
search/fix-test-resource-deployment
branch
from
5b99c25
to
1ced2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/search-documents
Issues associated with this PR
Describe the problem that is addressed by this PR
Live test resource deployment hasn't been working correctly. This aims to fix that, enable semantic search for semantic search tests, and allow for easier deployment of test resources.
Designed to be reviewed on a per-commit basis.
Fixes #24531
Fixes #26490
Fixes #27400
Fixes #27669
Checklists