[eslint-plugin] support Flat Config #29751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - some rules cannot be configured yet in azure-sdk-customized.ts
Also - fix `files` patterns for ts files. - add better typing for configs. - disable eslint-plugin-import for now as it doesn't support flat config yet.
jeremymeng
requested review from
ckairen,
deyaaeldeen,
mikeharder,
KarishmaGhiya,
maorleger,
schaabs,
a team,
kushagraThapar,
kirankumarkolli,
simorenoh,
v1k1,
xirzec,
timovv and
mpodwysocki
as code owners
|
API change check API changes are not detected in this pull request. |
mpodwysocki
reviewed
May 21, 2024
| @@ -24,20 +24,27 @@ | |||
| "bugs": { | |||
| "url": "https://github.com/Azure/azure-sdk-for-js/issues" | |||
| }, | |||
| "main": "dist/index.js", | |||
| "main": "dist-esm/src/index.js", | |||
| "exports": { | |||
There was a problem hiding this comment.
We should be using tshy here to ensure we have proper types for CJS and ESM. Otherwise these are only types for ESM and not CJS
There was a problem hiding this comment.
I will fix this in a follow-up PR.
mpodwysocki
approved these changes
May 21, 2024
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint v9 drops support for legacy .eslintrc style configuration files. To move to v9 we need to migrate to the new Flat Config files. This PR adds support for Flat Config file and migrate cosmos and identity-broker packages to use the flat config. Legacy config files are still supported.
Some eslint plugins that we use don't support flat config yet so they are disabled.
Related issue: #29750