Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Rollback query-string package to version 5 #4156

Merged

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Jul 3, 2019

query-string package uses arrow functions starting from version 6.
To add the support for IE, we are moving to an older version of query-string(version 5).

Quoting - https://github.com/sindresorhus/query-string/releases/tag/v6.0.0

We now target Node.js 6 or later and the latest version of Chrome, Firefox, and Safari. If you want support for older browsers, use version 5: npm install query-string@5. Same goes for Create React App v1 users (v2 works though), since it doesn't transpile node_modules.

@HarshaNalluru HarshaNalluru changed the title Rollback query-string package to version 5 [Storage] Rollback query-string package to version 5 Jul 3, 2019
@HarshaNalluru HarshaNalluru self-assigned this Jul 3, 2019
@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jul 3, 2019
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! But CI tests failed. it relates to Rush update that other packages depend on query-string v6. You may need to sync package.json of other packages to the same ersion.

The shrinkwrap file is missing the following dependencies:  
  "@types/query-string" (6.2.0) required by "@azure/storage-blob"
  "query-string" (^5.0.0) required by "@azure/storage-blob"
  "@types/query-string" (6.2.0) required by "@azure/storage-file"
  "query-string" (^5.0.0) required by "@azure/storage-file"
  "@types/query-string" (6.2.0) required by "@azure/storage-queue"
  "query-string" (^5.0.0) required by "@azure/storage-queue"

Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to update @types/query-string version?

@HarshaNalluru
Copy link
Member Author

Great job! But CI tests failed. it relates to Rush update that other packages depend on query-string v6.

I will push the updated pnpm-lock file.

@HarshaNalluru
Copy link
Member Author

HarshaNalluru commented Jul 3, 2019

Do you need to update @types/query-string version?

More info
@types/query-string is required for query-string - v5.
They deprecated @types/query-string after 6.2.0 because query-string - v6 started providing own @types directly from the package.

In order to use query-string - v5, we need @types/query-string - 6.2.0

This fixes the IE issue temporarily.
We might need to either look for an alternative for query-string package to support IE or add custom logic and avoid query-string altogether - #4161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants