Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Improve error messages when constructing client #4899

Merged
merged 9 commits into from
Aug 27, 2019
Merged

[Event Hubs] Improve error messages when constructing client #4899

merged 9 commits into from
Aug 27, 2019

Conversation

ShivangiReja
Copy link
Member

@ShivangiReja ShivangiReja commented Aug 26, 2019 •
edited

Based on UX Studies:

  • Connection string without EntityPath, and no event hub name parameter
    • The error message talks about path because it is coming from core-amqp. Add checks in Event Hubs and provide better error message
  • Throw Error when EntityPath in Connection string doesn't match with event hub name parameter

@ShivangiReja ShivangiReja self-assigned this Aug 26, 2019
ShivangiReja and others added 2 commits August 27, 2019 10:30
@ShivangiReja @ramya-rao-a
Update sdk/eventhub/event-hubs/src/eventHubClient.ts
51b6078 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
@ShivangiReja @ramya-rao-a
Update sdk/eventhub/event-hubs/src/eventHubClient.ts
d27d705 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
@ShivangiReja ShivangiReja merged commit 3d25b37 into Azure:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@chradek chradek Awaiting requested review from chradek

Assignees

@ShivangiReja ShivangiReja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShivangiReja @ramya-rao-a