[Service Bus] Increase timeout for settling msgs to 60sec #3764 #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
approved these changes
Aug 27, 2019
ramya0820
reviewed
Sep 11, 2019
| @@ -1031,7 +1030,7 @@ export class MessageReceiver extends LinkEntity { | |||
| "message may or may not be successful" | |||
| }; | |||
| return reject(translate(e)); | |||
| }, messageDispositionTimeout); | |||
| }, Constants.defaultOperationTimeoutInSeconds); | |||
There was a problem hiding this comment.
Uh oh, looks like this should have been converted to milliseconds here. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a timeout of 20 seconds for the message settle operation.
If the service does not acknowledge the result of the operation by then, we throw a timeout error.
It turns out that 60 sec is the default operation timeout to be used as per the libraries in other languages and as per the suggestion from the service team.
This PR makes this change for the timeout.
Related issue: #3764