[core-auth] Change GetTokenOptions to be based on OperationOptions #5899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
approved these changes
Oct 28, 2019
bterlson
approved these changes
Oct 28, 2019
|
/azp run js - keyvault - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run js - keyvault-keys - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - keyvault-secrets - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Approved by adpship. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
GetTokenOptionsto be solely based on the newOperationOptionsto achieve better consistency with the API signatures in other Track 2 client libraries. For now I'm duplicating the shapes ofOperationOptionsand its constituent types becausecore-authshouldn't take a circular dependency oncore-http. We will reorganize things in the future so that this won't be necessary.Fixes #5900