[Storage] Name properties on clients should support parsing more types of URLs - storage-blob #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
jeremymeng,
jiacfan,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
added
Client
HarshaNalluru
commented
Jan 7, 2020
| * Extracts account name from the blobEndpointUrl | ||
| * @param {string} blobEndpointUrl blobEndpointUrl to extract the account name from | ||
| * @returns {string} account name | ||
| */ | ||
| export function getAccountNameFromUrl(blobEndpointUrl: string): string { |
There was a problem hiding this comment.
Hey @XiaoningLiu,
I had updated only this one instance of getAccountNameFromUrl in the storage-file-datalake related to the name properties, please verify if there are more instances to take care of.
XiaoningLiu
approved these changes
Jan 8, 2020
| const parsedUrl: URLBuilder = URLBuilder.parse(blobEndpointUrl); | ||
| let accountName; | ||
| try { | ||
| if (parsedUrl.getHost()!.split(".")[1] === "blob") { |
There was a problem hiding this comment.
blob or dfs
datalake sdk uses 2 endpoints at the same time. Support both scenarios should be safe
There was a problem hiding this comment.
Updated accordingly, haven't introduced any new changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #6694 for storage-blob package
Fixes #5604