[Draft] [WIP] [Recorder] Using import for types #7056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
changed the title
HarshaNalluru
changed the title
xirzec
reviewed
Jan 22, 2020
| "dist-esm/test/*.spec.js", | ||
| "dist-esm/test/node/*.spec.js", | ||
| "dist-esm/src/index.js" | ||
| ]; | ||
| baseConfig.plugins.unshift(multiEntry()); | ||
|
|
||
| // different output file | ||
| baseConfig.output.file = "dist-test/index.node.js"; | ||
|
|
||
| // mark assert as external |
There was a problem hiding this comment.
should we update this comment since it's not just assert that is getting excluded now?
| dont_print: true | ||
| }); | ||
| if (!isBrowser()) { | ||
| import("nock").then((nock) => { |
There was a problem hiding this comment.
since import is async, I think record() should become an async function and then we can use await here.
| if (err.code !== "EEXIST") throw err; | ||
| } | ||
| if (!isBrowser()) { | ||
| import("nock").then((nock) => { |
…to harshan/issue/7033-import-only
HarshaNalluru
added
Client
…to harshan/issue/7033-import-only
HarshaNalluru
changed the title
|
@HarshaNalluru, Is this PR still relevant? What is pending here to get the PR out from the draft stage? |
|
I'll need to re-work since some of the changes here would be breaking, I'll check it out this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.