[Recorder] Remove function bunch - setReplaceableVariables, setReplacements, skipQueryParams #7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to harshan/PR-followup/7083-stg-q-remove-funcs
HarshaNalluru
requested review from
jeremymeng,
jiacfan,
sophiajt,
ljian3377,
sadasant,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
changed the title
HarshaNalluru
added
Client
62 tasks
HarshaNalluru
commented
Jan 29, 2020
Add [BREAKING] prefix to the statement.
sadasant
reviewed
Jan 29, 2020
sadasant
reviewed
Jan 29, 2020
sadasant
reviewed
Jan 29, 2020
sadasant
suggested changes
Jan 29, 2020
| env.SECRET = "SECRET"; | ||
| const replaceableVariables = {}; | ||
|
|
||
| setEnvironmentVariables(replaceableVariables); |
There was a problem hiding this comment.
Once setEnvironmentVariables has the environment object parametrized, this unit test won't need to change the global environment object!
There was a problem hiding this comment.
Updated, but still changing the global environment object to actually test the feature.
…to harshan/PR-followup/7083-stg-q-remove-funcs
…/github.com/HarshaNalluru/azure-sdk-for-js into harshan/PR-followup/7083-stg-q-remove-funcs
HarshaNalluru
commented
Jan 31, 2020
| @@ -14,7 +14,7 @@ export async function authenticate(that: any): Promise<any> { | |||
| AZURE_TENANT_ID: "azure_tenant_id", | |||
| KEYVAULT_NAME: "keyvault_name" | |||
| }, | |||
| replaceInRecordings: [ | |||
| customizationsOnRecordings: [ | |||
| (recording: any): any => | |||
There was a problem hiding this comment.
Heads up on the rename, @willmtemple !!
…to harshan/PR-followup/7083-stg-q-remove-funcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the PR
Changes in the recorder package
replaceableVariables,queryParameters,replacementsthat are being globally set.BaseRecorderclass and passing them as arguments to the functions that use them whenever required.setReplaceableVariables,setReplacements,skipQueryParamsand hence removed the three functions.setEnvironmentVariables, which is as of now used for playback only (there are plans for its usage insoft-record).setEnvironmentVariables.Changes in recorder, storage and keyvault packages
replaceInRecordings->customizationsOnRecordingsreplaceInRecordingsattribute ofRecorderEnvironmentSetuptocustomizationsOnRecordingswhich I think is more appropriate.(And also I couldn't wrap my head around too many
replace-prefixed words.)replaceInRecordingsin the storage and keyvault tests.