Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[event-hubs] add security_token to management apis #7463

Merged
merged 2 commits into from Feb 21, 2020
Merged

[event-hubs] add security_token to management apis #7463

merged 2 commits into from Feb 21, 2020

Conversation

chradek
Copy link
Contributor

@chradek chradek commented Feb 20, 2020 •
edited

Adds the security_token field for management apis in event hubs. Java and .NET already do this.

While testing event-hubs in Azure Stack we observed that the management APIs would throw unauthorized errors if the security_token wasn't present.

@jfggdl jfggdl marked this pull request as ready for review February 20, 2020 23:13
richardpark-msft
richardpark-msft reviewed Feb 21, 2020
View reviewed changes
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks "fine" in that the code looks okay but....what does this do? What wasn't working because of this?

sdk/eventhub/event-hubs/src/managementClient.ts Show resolved Hide resolved
@chradek
Copy link
Contributor Author

chradek commented Feb 21, 2020

/azp run js - eventhubs-client - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chradek
Copy link
Contributor Author

chradek commented Feb 21, 2020

Updated the description and added a changelog entry to provide more details on why this is needed.

richardpark-msft
richardpark-msft approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the context now everything is clear. Nominating for best PR of 2020.

@chradek chradek merged commit 6f41979 into Azure:master Feb 21, 2020
@chradek chradek deleted the event-hubs-security-token branch February 21, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpark-msft richardpark-msft richardpark-msft approved these changes

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chradek @richardpark-msft