Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cognitive.Vision.Face Identify MaxNumberOfCandidatesReturned doesn't match docs #14027

Closed
danzel opened this issue Aug 7, 2020 · 6 comments
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Face customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.

Comments

@danzel
Copy link

danzel commented Aug 7, 2020

Describe the bug
You cannot call Identify with maxNumberOfCandidatesReturned > 5

Expected behavior
The documentation says this value can be 1-100 with a default of 10.
https://westus.dev.cognitive.microsoft.com/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395239

maxNumOfCandidatesReturned (optional) | Number | The range of maxNumOfCandidatesReturned is between 1 and 100 (default is 10).

Actual behavior (include Exception or Stack Trace)
Microsoft.Rest.ValidationException: 'maxNumOfCandidatesReturned' exceeds maximum value of '5'.

To Reproduce

FaceClient.Face.IdentifyAsync(..., largePersonGroupId: largePersonGroupId, maxNumOfCandidatesReturned: 10);

Environment:

  • Microsoft.Azure.CognitiveServices.Vision.Face 2.5.0-preview.1
  • Azure AppService .net core
  • Visual Studio 16.4.6
@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 7, 2020
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Cognitive - Face needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team. labels Aug 7, 2020
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Aug 7, 2020
@jsquire
Copy link
Member

jsquire commented Aug 7, 2020

Thank you for your feedback. Tagging and routing to the team best able to assist.

@ghost
Copy link

ghost commented Aug 7, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @JinyuID, @dipidoo, @SteveMSFT.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

Hi @danzel. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2021
@ghost
Copy link

ghost commented Mar 13, 2021

Hi @danzel. There was a mistake and this issue was unintentionally flagged as a stale pull request. The label has been removed and the issue will remain active; no action is needed on your part. Apologies for the inconvenience.

@KranthiPakala-MSFT
Copy link

@JinyuID , @dipidoo , @SteveMSFT - Could you please have a look at this feedback and share your thoughts? - Thank you

@danzel
Copy link
Author

danzel commented Sep 19, 2022

Looks like this was fixed in #25236

@danzel danzel closed this as completed Sep 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Face customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants