Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebJobs][EventGrid] Support Cloud Events in EventGrid WebJobs Extensions #15466

Closed
2 of 3 tasks
ellismg opened this issue Sep 25, 2020 · 6 comments · Fixed by #21612
Closed
2 of 3 tasks

[WebJobs][EventGrid] Support Cloud Events in EventGrid WebJobs Extensions #15466

ellismg opened this issue Sep 25, 2020 · 6 comments · Fixed by #21612
Assignees
Labels
Event Grid Extensions ASP.NET Core extensions
Milestone

Comments

@ellismg
Copy link
Member

ellismg commented Sep 25, 2020

There are a few moving pieces here:

  • For the trigger binding, the handshake between the service and the listener when creating a subscription is different. Instead of sending a "SubscriptionValidationEvent" and expecting a certain response object, the service instead follows a different handshake where an OPTIONS request is sent to the underlying webhook (see: https://github.com/cloudevents/spec/blob/1085aeee96d0efd625dd1654a625064fde4be6ac/http-webhook.md#41-validation-request)
  • The trigger will need to handle deserializing the event payload into the Cloud Event model type.
  • Output binding will need to accept CloudEvent model types as well.
@ellismg ellismg added Event Grid Extensions ASP.NET Core extensions labels Sep 25, 2020
@ellismg ellismg added this to the [2020] November milestone Sep 25, 2020
@ellismg ellismg self-assigned this Sep 25, 2020
@ellismg
Copy link
Member Author

ellismg commented Sep 25, 2020

/cc @pakrym . I should be able to handle this next milestone (for the November release)

@ellismg
Copy link
Member Author

ellismg commented Jun 3, 2021

Spoke with @JoshLove-msft who's been maintaining the EventGrid trigger. We've made some progress here but we might have not done the first bullet so it may not be possible right now to set a function as a target for a subscription of cloud events. He's going to take a look - but that's likely the only gap left.

@JoshLove-msft
Copy link
Member

Beyond the subscription validation handling, you currently cannot create a CloudEventSchema event subscription for an Azure Function.

@Expecho
Copy link

Expecho commented Jun 4, 2021

@JoshLove-msft

Beyond the subscription validation handling, you currently cannot create a CloudEventSchema event subscription for an Azure Function.

Does that mean it will be available some time?

@JoshLove-msft
Copy link
Member

@JoshLove-msft

Beyond the subscription validation handling, you currently cannot create a CloudEventSchema event subscription for an Azure Function.

Does that mean it will be available some time?

That is the goal, but we don't have a definite timeline yet.

@JoshLove-msft
Copy link
Member

This turned out to not be the case. There is special handling in the service for the handshake when the subscription is using Azure Functions. In this case it uses the same HttpPostChallenge mechanism as for EventGridSchema since users wouldn't need to interact with this flow in general. However, there were issues in the format of how the CloudEvent HttpPostChallenge is delivered that required fixes.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Event Grid Extensions ASP.NET Core extensions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants