Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation Readme issues #18183

Closed
v-xuto opened this issue Jan 26, 2021 · 4 comments · Fixed by #19926
Closed

Attestation Readme issues #18183

v-xuto opened this issue Jan 26, 2021 · 4 comments · Fixed by #19926
Assignees
Labels
Attestation Client This issue points to a problem in the data-plane of the library. Docs Service Attention This issue is responsible by Azure service team. test-manual-pass

Comments

@v-xuto
Copy link
Member

v-xuto commented Jan 26, 2021

Section link:
image

Reason:No create_thing method .

Suggestion: Delete the whole part about Create the thing.

Section link:
image

Suggestion:
We should keep the items listed in sample summary match to the headlines.
Update Get the thing to Get an attestation policy for a specified attestation type.
Update List the things to Set an attestation policy for a specified attestation type.

Section link:
image

Reason:No list_things method.
Suggestion: Delete the code things = client.list_things()

@jongio for notification.

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 26, 2021
@tzhanl tzhanl added Attestation Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage This issue needs the team to triage. test-manual-pass labels Jan 26, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 26, 2021
@jsquire jsquire added the Service Attention This issue is responsible by Azure service team. label Jan 26, 2021
@ghost
Copy link

ghost commented Jan 26, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @anilba06.

Issue Details

Section link:
image

Reason:No create_thing method .

Suggestion: Delete the whole part about Create the thing.

Section link:
image

Suggestion:
We should keep the items listed in sample summary match to the headlines.
Update Get the thing to Get an attestation policy for a specified attestation type.
Update List the things to Set an attestation policy for a specified attestation type.

Section link:
image

Reason:No list_things method.
Suggestion: Delete the code things = client.list_things()

@jongio for notification.

Author: v-xuto
Assignees: LarryOsterman
Labels:

Attestation, Client, Docs, Service Attention, needs-team-triage, test-manual-pass

Milestone: -

@jsquire jsquire removed the needs-team-triage This issue needs the team to triage. label Jan 26, 2021
@LarryOsterman
Copy link
Member

Funny you should mention that - I just went through building a decent one for Java, let me see what I can do about transferring it.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

Hi @v-xuto. There hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by removing the no-recent-activity label. Otherwise, we'll close this out in 7 days.

@LarryOsterman LarryOsterman removed the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@LarryOsterman
Copy link
Member

Removed the label - I've been working on other issues, getting back to this one soonish.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Attestation Client This issue points to a problem in the data-plane of the library. Docs Service Attention This issue is responsible by Azure service team. test-manual-pass
Projects
None yet
4 participants