Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor Query] Support resource-centric logs queries #26638

Closed
4 tasks
AtOMiCNebula opened this issue Jan 27, 2022 · 5 comments
Closed
4 tasks

[Monitor Query] Support resource-centric logs queries #26638

AtOMiCNebula opened this issue Jan 27, 2022 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention This issue needs attention from Azure service team or SDK team
Milestone

Comments

@AtOMiCNebula
Copy link

AtOMiCNebula commented Jan 27, 2022

Library name

Azure.Monitor.Query

Please describe the feature.

It looks like Azure.Monitor.Query's LogsQueryClient can only query workspaces, but not resources (https://docs.microsoft.com/en-us/azure/azure-monitor/logs/api/azure-resource-queries). I want to set up some API calls to query Key Vault resources, and it looks like if I perform all my own stunts this is possible, but it'd be nice if the SDK supported this too. Would be great for some SDK support here.

Checklist added by @scottaddie:

  • Add API surface to support new /{resourceId}/query endpoint
  • Add code example
  • Update README (we currently say a workspace ID is a prerequisite, but I don't think that's true for the new endpoint)
  • Update troubleshooting guide
@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jan 27, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'ARM:0.12535079,KeyVault:0.08972482,Monitor - Exporter:0.06807664'
Label prediction was below confidence level 0.6 for Model:CategoryLabels: 'Mgmt:0.58093184,Client:0.37477067,Service:0.043131437'

@AtOMiCNebula AtOMiCNebula changed the title [BUG] Azure.Monitor.Query doesn't allow log queries against resources, only workspaces [FEATURE REQ] Azure.Monitor.Query doesn't allow log queries against resources, only workspaces Jan 27, 2022
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Monitor - Query needs-team-attention This issue needs attention from Azure service team or SDK team labels Jan 27, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 27, 2022
@jsquire
Copy link
Member

jsquire commented Jan 27, 2022

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@scottaddie
Copy link
Member

@AtOMiCNebula Thank you for the feature request. It's been added to the product backlog. I'm working with the Azure Monitor service team to prioritize the necessary changes on their end. Work is expected to begin as soon as April.

@scottaddie scottaddie added 0 - Backlog and removed needs-team-attention This issue needs attention from Azure service team or SDK team labels Feb 16, 2022
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Feb 16, 2022
@AtOMiCNebula
Copy link
Author

Thanks! For now, we're working around this limitation by specifying our own HttpClientTransport that rewrites workspace query URLs to target resources instead, but it'll be nice to have proper SDK support. 😄

@scottaddie scottaddie added feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 16, 2022
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Feb 16, 2022
@scottaddie scottaddie added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jun 15, 2022
@jsquire jsquire added this to the Backlog milestone Sep 2, 2022
@jsquire jsquire removed the Monitor Monitor, Monitor Ingestion, Monitor Query label Sep 2, 2022
@scottaddie scottaddie changed the title [FEATURE REQ] Azure.Monitor.Query doesn't allow log queries against resources, only workspaces [Monitor Query] Support resource-centric logs queries Mar 1, 2023
@scottaddie scottaddie modified the milestones: Backlog, 2023-04 Mar 1, 2023
@jsquire jsquire modified the milestones: 2023-04, Backlog Apr 18, 2023
@scottaddie
Copy link
Member

scottaddie commented May 1, 2023

v1.2.0-beta.1 shipped today and includes this feature. See https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/monitor/Azure.Monitor.Query/CHANGELOG.md#120-beta1-2023-05-09.

@scottaddie scottaddie modified the milestones: Backlog, 2023-05 May 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention This issue needs attention from Azure service team or SDK team
Projects
None yet
Development

No branches or pull requests

5 participants