Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignalR Trigger supports base64 encoded claims #27404

Closed
2 tasks
Y-Sindo opened this issue Mar 8, 2022 · 1 comment
Closed
2 tasks

SignalR Trigger supports base64 encoded claims #27404

Y-Sindo opened this issue Mar 8, 2022 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. SignalR
Milestone

Comments

@Y-Sindo
Copy link
Member

Y-Sindo commented Mar 8, 2022

Library name

Microsoft.Azure.WebJobs.Extensions.SignalRService

Please describe the feature.

Currently SignalR serverless protocol uses a format like "a: v, b: v" to represent users' claims, which causes some problems including but not limited to:

  1. Claim values are truncated at first comma  #27225
  2. Multiple jwt claims of the same type not supported? azure-functions-signalrservice-extension#260, Only one claim of type 'role' is returned to the hub azure-signalr#1084

To solve these problems, we intend to add a new header X-ASRS-User-Claims-Encoded to hold the base64 encoded claims. The fix requires both an ASRS runtime change and SignalR Functions extension change.

  • ASRS runtime change
  • SignalR Functions extension change
@Y-Sindo Y-Sindo self-assigned this Mar 8, 2022
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Functions SignalR labels Mar 8, 2022
@jsquire jsquire added this to the Backlog milestone May 19, 2022
@jsquire jsquire removed the Functions label Mar 4, 2024
Copy link

github-actions bot commented Apr 3, 2024

Hi @Y-Sindo, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. SignalR
Projects
Development

No branches or pull requests

2 participants