Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeGenerator generates "Operation returned an invalid status code 'XYZ'" #4012

Closed
matthchr opened this issue Jan 24, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@matthchr
Copy link
Member

We've had a number of customers complain or get confused about the fact that the generated text in the exception is an invalid status code (even though the status code is listed in string form afterwards).

I personally actually see where they are coming from - "Invalid" makes me thing of an HTTP status code which is not a valid status code (i.e. returning -1 or something).

It would be clearer if this text said something like: "Operation returned an unexpected status code 'XYZ'" or "Operation returned an HTTP status code 'XYZ' which does not represent a success"

Is a change like this something you'd be open to?

@shahabhijeet
Copy link
Member

@matthchr yes we are open to such changes.
Can you give me a precise repro so we know which code path is causing such error strings.

@shahabhijeet shahabhijeet added this to the March 2018 milestone Mar 27, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Apr 2, 2018

@matthchr Improving the messaging in auto generated exceptions is something we have worked on in the CSharp generator but it hasn't been released yet. We should probably be able to take this change in the generator repo. Will reopen this issue there.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants