Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

AtomHandler.parse shouldn't ever try to guess a type of a property value #114

Closed
smarx opened this issue Mar 15, 2012 · 2 comments
Closed

Comments

@smarx
Copy link
Contributor

smarx commented Mar 15, 2012

See http://stackoverflow.com/questions/9687872/azure-sdk-for-node-is-rounding-large-numbers-in-json-responses for what can go wrong.

AtomHandler.parse uses a "convertTypes" parameter to decide whether it should try to guess at properties that don't have an explicit type. I don't think this is ever the right thing to do. I believe the default type on a value in OData is Edm.String.

My suggestion would be to get rid of the "convertTypes" parameter and always return a string value when there's no explicit type.

@ghost ghost assigned andrerod Apr 17, 2012
@andrerod
Copy link

We should definetely fix this.

@andrerod
Copy link

Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants