Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

QueryString should not be in the wrap authentication #86

Closed
andrerod opened this issue Feb 22, 2012 · 3 comments
Closed

QueryString should not be in the wrap authentication #86

andrerod opened this issue Feb 22, 2012 · 3 comments
Assignees

Comments

@andrerod
Copy link

This will cause cache to be refreshing more than needed.

#86

@ghost ghost assigned andrerod Feb 22, 2012
@andrerod
Copy link
Author

Can be done later.

@paed01
Copy link

paed01 commented May 23, 2013

Regarding module Wrap: lib/services/serviceBus/internal/wrap.js

Shouldn’t the signRequest function be something like this to prevent unnecessary calls to acs:

Wrap.prototype.signRequest = function (webResource, callback) {
var parsedUrl = url.parse(webResource.requestUrl);
parsedUrl.protocol = 'http:';
delete parsedUrl.pathname;
delete parsedUrl.host;
delete parsedUrl.port;
delete parsedUrl.search;
var requestUrl = url.format(parsedUrl);

The committed function tries to delete parsedUrl.path property. That property is not documented in the url-module. The search property deletes the query string.

andrerod pushed a commit that referenced this issue Sep 17, 2013
@andrerod andrerod removed their assignment Apr 1, 2014
@azuresdkci azuresdkci changed the title QueryString should not be in the wrap authentication Duplicate item created by TFS bridge 172 Aug 11, 2014
@andrerod andrerod reopened this Aug 11, 2014
@andrerod andrerod changed the title Duplicate item created by TFS bridge 172 QueryString should not be in the wrap authentication Aug 11, 2014
@azuresdkci azuresdkci reopened this Aug 25, 2014
@azuresdkci azuresdkci added P4 and removed P3 labels Aug 25, 2014
@yugangw-msft
Copy link
Contributor

closing as part of xplat backlog scrub

amarzavery added a commit to amarzavery/azure-sdk-for-node that referenced this issue May 4, 2015
Update client with NRP LB and NIC changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants