This repository has been archived by the owner on May 5, 2023. It is now read-only.
Github support #394
Merged
Github support #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 18, 2012 02:20
added 11 commits
October 22, 2012 15:27
|
|
||
| LinkedRevisionControlClient.getRepository = function (repositories, remoteUri) { | ||
| var parsedRepositoryUri = url.parse(remoteUri); | ||
| var pathParts = parsedRepositoryUri.pathname.split('/'); |
There was a problem hiding this comment.
Check initial slash. Consider comparing full name.
| context.lvcClient.init(context, _); | ||
|
|
||
| // Scaffold | ||
| copyIisNodeWhenServerJsPresent(_); |
There was a problem hiding this comment.
Wasn't this going to be moved upwards out of this if block?
There was a problem hiding this comment.
If we do decide to move, it'll be the iisnode scaffolding. But we still havent settled. So for now its going to proceed with the same behavior as powershell. Follow up / stabilization / finalization issues will follow.
|
One question, otherwise LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.