Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Expose a send_request method on KV clients #25172

Closed
mccoyp opened this issue Jul 11, 2022 · 3 comments
Closed

[Key Vault] Expose a send_request method on KV clients #25172

mccoyp opened this issue Jul 11, 2022 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault MQ This issue is part of a "milestone of quality" initiative.
Milestone

Comments

@mccoyp
Copy link
Member

mccoyp commented Jul 11, 2022

Using DPG, we should add a send_request method to KV clients so that clients can send requests that there's no specific API surface for, using the same auth and pipeline that other client requests do. This would be particularly helpful for cases when the Azure CLI needs to send requests for new service features via the Python SDK.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. DPG labels Jul 11, 2022
@mccoyp mccoyp added this to the 2022-08 milestone Jul 11, 2022
@mccoyp mccoyp self-assigned this Jul 11, 2022
@mccoyp mccoyp modified the milestones: 2022-08, 2022-09 Aug 18, 2022
@mccoyp mccoyp modified the milestones: 2022-09, 2022-10 Sep 1, 2022
@mccoyp mccoyp modified the milestones: 2022-10, 2022-11 Oct 14, 2022
@mccoyp
Copy link
Member Author

mccoyp commented Oct 14, 2022

Update to this: there should actually already be a send_request method on generated clients. (DPG isn't currently applicable to KV because we use the multi-API generation script with autorest). We just need to expose this method on top-level clients.

@mccoyp mccoyp modified the milestones: 2022-11, 2022-12 Nov 16, 2022
@mccoyp mccoyp modified the milestones: 2022-12, 2023-01 Dec 5, 2022
@mccoyp mccoyp added MQ This issue is part of a "milestone of quality" initiative. and removed DPG labels Dec 5, 2022
@mccoyp
Copy link
Member Author

mccoyp commented Dec 8, 2022

Update (again): there are _send_request methods on generated clients, but only on API version-specific clients (example). However, since KV uses multi-API generation, our top-level clients don't actually use these clients and instead are built on the multi-API client -- which doesn't have this method.

The implementation is very straightforward, so we can just implement send_request ourselves for now. But once the generated method is available on a client that we actually use, we should probably switch to using its implementation.

@mccoyp mccoyp modified the milestones: 2023-01, 2023-02 Jan 10, 2023
@mccoyp mccoyp modified the milestones: 2023-02, 2023-03 Feb 23, 2023
@mccoyp
Copy link
Member Author

mccoyp commented Mar 14, 2023

Resolved by #29124

@mccoyp mccoyp closed this as completed Mar 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault MQ This issue is part of a "milestone of quality" initiative.
Projects
Archived in project
Development

No branches or pull requests

1 participant