Fix Pylint warnings for the new checkers #26269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-python into ostoliarova/sdk-communication/pylint_warnings
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-communication-identity |
|
The changes, look fine to me. cc: @radubulboaca |
ostoliarova-msft
requested review from
petrsvihlik,
maximrytych-ms,
elavarasidc,
shirleyqin-msft,
LuChen-Microsoft and
Shamkh
shirleyqin-msft
approved these changes
Sep 29, 2022
sdk/communication/azure-communication-chat/azure/communication/chat/_chat_client.py
Outdated
Show resolved
Hide resolved
|
@ostoliarova-msft pls apply the pylint changes for the azure-communication-jobrouter as well |
AikoBB
reviewed
Sep 30, 2022
sdk/communication/azure-communication-chat/azure/communication/chat/_api_versions.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_chat_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_chat_thread_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/aio/_chat_client_async.py
Outdated
Show resolved
Hide resolved
...unication/azure-communication-chat/azure/communication/chat/aio/_chat_thread_client_async.py
Outdated
Show resolved
Hide resolved
...mmunication-phonenumbers/azure/communication/phonenumbers/aio/_phone_numbers_client_async.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-rooms/azure/communication/rooms/_rooms_client.py
Outdated
Show resolved
Hide resolved
...communication/azure-communication-rooms/azure/communication/rooms/aio/_rooms_client_async.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-sms/azure/communication/sms/_sms_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-sms/azure/communication/sms/aio/_sms_client_async.py
Outdated
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-communication-identity |
…for-python into ostoliarova/sdk-communication/pylint_warnings
|
/azp run python - azure-communication-phonenumbers - tests |
|
/azp run python - azure-communication-chat - tests |
|
/azp run python - azure-communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - azure-communication-email - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - azure-communication-jobrouter - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - azure-communication-networktraversal - tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failing tests for sip routing shouldnt be a blocker, it's a problem with test data that we're going to fix. |
|
/check-enforcer override |
AikoBB
approved these changes
Oct 19, 2022
yogeshmo
approved these changes
Oct 19, 2022
|
@ostoliarova-msft one last thing, pls mention that we are providing the ability to specify the API version by |
petrsvihlik
approved these changes
Oct 20, 2022
ajpeacock0
approved these changes
Oct 20, 2022
radubulboaca
approved these changes
Oct 20, 2022
xiangyan99
added a commit
that referenced
this pull request
Oct 27, 2022
* [SchemaRegistry] docs/update release date (#26736) * [Storage] Fix flaky test in `test_file.py` migration (#26735) * Be gone flaky test * Live only tag * Default variable empty pop * RC (#26733) * [AutoRelease] t2-resource-2022-10-10-38276(Do not merge) (#26724) * code and test * fix test Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-dataprotection-2022-10-03-74033(Do not merge) (#26590) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * code and test (#26745) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * feat: support setting path for node output directly (#26712) * feat: support setting path for node output directly * fix: fix ci * refactor: remove redundant _inputs_outputs.py (#26714) * fix broken links (#26746) * Update service client and client and add new api version (#25865) * Update service client and client and add new api version * Update parameter type * Add tests, update test recordings, samples, readme and changelog * Rename token expiration parameter based on review * reverted back unwanted changes in ml sdk * fixed doctype * fixed linting issues Co-authored-by: Aigerim Beishenbekova <aigerimb@microsoft.com> * Search deeper in from_config so that config.json is found in Compute Instance (#26737) * Add DictMixin to easy AML SDK classes (#26365) * copy ADO branch changes into GH branch * sync with closed source comments * fix merge issues * continue to fix changelog file merge issues * move CL entry to correct section * Increment package version after release of azure-identity (#26749) * Add schema links to error messages resolution section (#26646) * Add specific datastore types to ErrorTarget enum * Add schema links to error messages resolution sections * Add test * Update datastore ErrorTarget enum * Update to use proper key for yaml ref doc dictionary * Fix pylint errors * Update Resolution message * Update Resolution message * Update test * Update test * Fix broken symlink test * target version with fixes (#26702) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Update the release versions for ML SDK (#26752) * Update the release versions for ML SDK * Update the readme for ML project for GA * Update version in setup file * Increment package version after release of azure-servicebus (#26765) * Increment version for tables releases (#26767) Increment package version after release of azure-data-tables * Increment version for storage releases (#26761) Increment package version after release of azure-storage-file-share * Update swagger_to_sdk_config_autorest.json (#26772) * [Storage] Migrate `test_share` to test proxy (file-share) (#26709) * Live sync done * Sync recorded done * Fix imports * Async live done * All passing async recorded * Fix imports again * Fix requests import ordering * [Storage] Migrate `test_file_service_properties.py` to test proxy (file-share) (#26770) * Delete and initial script run * Finished sync * Fixed .yaml being generated, all passing * [Storage] Migrate `test_get_file.py` to test proxy migration (file-share) (#26764) * Finished live after changing test acc * All passing live async * All passing live and recorded, reorder imports * [AutoRelease] t2-elasticsan-2022-09-19-73442(Do not merge) (#26291) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * [AutoRelease] t2-appcontainers-2022-10-05-17273(Do not merge) (#26634) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * fix: combo fix for internal components I (#26718) * fix: support data-binding expression on internal node runsettings * fix: raise error if unknown field errors are met in load_funcs * fix: support is_control output for internal components * feat: ignore unknown fields on internal output port definition instead of raising error * feat: enable hdinsight.compute_name * feat: support dependency files in additional_includes * feat: convert hdinsight.compute_name to arm str * feat: load all internal nodes to their own entity class instead of base node * resolve comment add * to validation class method remove super class for InternalOutputSchema * Fix sampleRate in AppInsightsSampler (#26771) * [Communication] - Phone Numbers - Use static connection string in azure-communication-phonenumber tests (#26775) * Use static connection string in phonenumber tests * Use static connection string for SIP tests * [Storage] Fix type hints for classmethods in Blob and Datalake (#26611) * [Storage] Adjust type hints for __init__ and classmethods in file-share, queue, and changefeed (#26743) * Bump the code owner retriver version. (#26789) Co-authored-by: sima-zhu <sizhu@microsoft.com> * [AutoRelease] t2-network-2022-10-10-01607(Do not merge) (#26726) * code and test * test fix * changelog date Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-securitydevops-2022-10-12-19159(Do not merge) (#26777) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * refactor: divide pipeline._io into a package (#26781) * [auto release] add `dev_requirements.txt` for new service to pass CI (#26799) * dev_requirement * code * Create dev_requirements.txt (#26802) * Update elasticsan requirements (#26804) Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> * feat: re-enable failed dsl tests (#26782) * feat: re-enable test_dsl_pipeline_samples.py * feat: re-enable skipped tests in test_dsl_pipeline.py * feat: re-enable left skipped tests * [ML][Pipeline] Fix sub graph job download (#26803) * Add schedule doc string, fix job download Signed-off-by: Brynn Yin <biyi@microsoft.com> * Enable create pipeline component from job test Signed-off-by: Brynn Yin <biyi@microsoft.com> * Add job compute validate test Signed-off-by: Brynn Yin <biyi@microsoft.com> * Fix docstring Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Brynn Yin <biyi@microsoft.com> * Add more example of transport (#26768) * Add more example of transport See #26757 * Update CLIENT_LIBRARY_DEVELOPER.md * Update CLIENT_LIBRARY_DEVELOPER.md * Update CLIENT_LIBRARY_DEVELOPER.md * Update CLIENT_LIBRARY_DEVELOPER.md Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> * allow subscription-only requests for registry list operation (#26674) * allow subscription only list calls for registry list * cl * change scope values to constant, correct ml * correct lower call * use scope constants for WS list function * move cl entry to correct file. * correct cl again * fix changelog syntax * [Azure Maps] - Onboarding for Render SDK (#24893) * init PR * Update samples * Add Unit/Live test Update testresopurce.json Update Minor Update * Update according to feedback * Code clean up * Update API to the newest version * Update to fix CI issue * Add recording files * update according to comment * Update docstrings * udpate accordingly * Update according to feedback * update minors according to feedback * update release date * skip aad tests since they fail in PPE (#26808) * [Storage] Remove `msrest` dependency (#26739) * update changelog date and ref docs (#26811) * Azure App Configuration Provider Beta (#26016) * Adding azure-appconfiguration-provider * Fixing repo issue * Fixing repo issue * Updated to setup user agent and header info * Updating to cache secret_clients * Fixed Naming * Fixed Typo * Added Samples, Fixed issue with Key Vault Options not set when secret is in store. * Fixed SP, Dependency, and Pylint issues * Fixed more lint issues, moved key vault references to be a method * More Linting fixes * Fixing dependency issues with build * Updated Docs. Fixed extra code for Key Vault Usage. Updated Readme to include a list of features and future features. Added Clients sample for Key Vault. * Adding Test Case, currently doesn't work * Fixing Tests * Fixing Trim. Fixing Typo in readme. * Fixing Length and vault_url issues. * Updating from code review comments * Added more error checking. Made Key_VAULT_SECRET_PREFIX a constant. * Updated to use Key Vault Identifier. * Fixed Spelling * Updated Test * Reworked key vault reference resolution. Fixed lint issues. * Fixing Lint Issue. Updating Test Running * Fixing Tests * Fixed Tests? * Setting secret clients to {} if none. Adding override to shared_requirements * Updating shared requirements * Fixed override. Switched to SecretReferenceConfigurationSetting * Updated Requirement KeyVaultSecretIdentifier is needed. * Update ci.yml * Update ci.yml * Fixed structure * Update dev_requirements.txt * Update sdk_packaging.toml * Revert working state * Renamed correctly * Using azure-appconfigurationprovider * Fixing shared Requirements merge issue * Updated from review comments * Fixing package folder * Fix lint, removed extra fixture * Create py.typed * Updated Manifest to use right py.typed file * Switched Files * Fixing lint issue * Setting defaults for test * Updating Docs * Fixing Whitespace * Updating to support in operation * Updated sample with in usage * Cleaned up key trimming usage * Removed extra catches for now. Cleaned up lint. * Adding more tests * Fixed Linting * Fixing Auto Format * Fixing Key Vault Reference Test * Trying to update the package name * Fixed formatting? * Adding azure-appconfiguration-provider * Fixing repo issue * Fixing repo issue * Updated to setup user agent and header info * Updating to cache secret_clients * Fixed Naming * Fixed Typo * Added Samples, Fixed issue with Key Vault Options not set when secret is in store. * Fixed SP, Dependency, and Pylint issues * Fixed more lint issues, moved key vault references to be a method * More Linting fixes * Fixing dependency issues with build * Updated Docs. Fixed extra code for Key Vault Usage. Updated Readme to include a list of features and future features. Added Clients sample for Key Vault. * Adding Test Case, currently doesn't work * Fixing Tests * Fixing Trim. Fixing Typo in readme. * Fixing Length and vault_url issues. * Updating from code review comments * Added more error checking. Made Key_VAULT_SECRET_PREFIX a constant. * Updated to use Key Vault Identifier. * Fixed Spelling * Updated Test * Reworked key vault reference resolution. Fixed lint issues. * Fixing Lint Issue. Updating Test Running * Fixing Tests * Fixed Tests? * Setting secret clients to {} if none. Adding override to shared_requirements * Updating shared requirements * Fixed override. Switched to SecretReferenceConfigurationSetting * Updated Requirement KeyVaultSecretIdentifier is needed. * Update ci.yml * Update ci.yml * Fixed structure * Update dev_requirements.txt * Update sdk_packaging.toml * Revert working state * Renamed correctly * Using azure-appconfigurationprovider * Fixing shared Requirements merge issue * Updated from review comments * Fixing package folder * Fix lint, removed extra fixture * Create py.typed * Updated Manifest to use right py.typed file * Switched Files * Fixing lint issue * Setting defaults for test * Updating Docs * Fixing Whitespace * Updating to support in operation * Updated sample with in usage * Cleaned up key trimming usage * Removed extra catches for now. Cleaned up lint. * Adding more tests * Fixed Linting * Fixing Auto Format * Fixing Key Vault Reference Test * Trying to update the package name * Removing Extra TestProxy * Not -e installing azure-appconfiguration * updates * update * update * Update sdk/appconfiguration/azure-appconfiguration-provider/setup.py Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> * update * Updated min version of app config * Updating sanitizer * Updating Shared Requirement * Temp removing key vault test * Removing actual tests Co-authored-by: Xiang Yan <xiangyan@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> * more readme fixes (#26815) * Increment version for cognitivelanguage releases (#26819) Increment package version after release of azure-ai-language-questionanswering * Update CHANGELOG.md (#26820) * Update CHANGELOG.md (#26821) * code and test (#26805) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Increment version for appconfiguration releases (#26823) Increment package version after release of azure-appconfiguration-provider * [Storage] Migrate `test_file_api_version.py` to test proxy (file-share) (#26812) * Initial script pass, sync done * Passing async * Fix imports * code and test (#26797) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Azure-communication-identity release updates (#26809) * [Azure Maps] - Onboarding for Route SDKs (#25101) * init * Update client, add samples * Update and expose models * Minor Update/clean up Update samples and tests Modify docstring * Delete and update uplicated intro in README * Update - Combine get route directions methods and post route directions methods - Minor update according to feedback * Update docstring * update test with test_proxy * update according to feedback * update to new autorest generated files * update exposed models * update according to feedback * update release date & minor naming & clean up` * Add overload methodst * fix pylint * [Storage] Add `aio` extra_requires to Storage packages (#26791) * Fix #26720, ContainerClient.from_container_url cannot work with URL ending with / (#26721) Co-authored-by: Yulin Li <Yulin.Li@microsoft.com> * [Asset-Sync] extensions to the test framework to allow external assets (#26078) * add updated logic to resolve assets.json and pass along to record|playback/start * ensure that parallel tox environments don't accidentally stomp on each other by updating where the local proxy assets are stored during CI runs * add assets cleanup to ensure we don't overfill the CI agents disks Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * [azure-sdk-tools] ensure trailing / in PROXY_URL can't mess with proxy startup (#26832) * [Storage] Migrate `test_file_client.py` to test proxy (file-share) (#26769) * Initial delete recordings + run migration script * Sync,live passing * Sync is done, async is failing live, but also qq on empty tests * Making async def even w/o async operations fixes double-backing on clients * Fix imports * Get rid of empty recordings, mark as live only * Removed live-only tag, still passes in live&recorded w/ no serv. call * [Key Vault] Move recordings into assets repository (#26837) * [TA] skip tests which are failing due to service bugs (#26838) * skip tests which are failing due to service bugs * fix with the correct link to the bug * Add Azure ML Pipeline CODEOWNERS (#26710) * update code owners * add more paths Co-authored-by: Clement Wang <clwan@microsoft.com> * [AutoRelease] t2-datafactory-2022-10-09-06495(Do not merge) (#26717) * code and test * Update CHANGELOG.md * Update _version.py * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: zhenbiao wei <424401670@qq.com> * Move back annotation conversion from mldesigner (#26843) Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Brynn Yin <biyi@microsoft.com> * [Identity] Doc formatting fixes (#26664) - Fixed a few issues with docs not being rendered as expected on the api docs website. - Added a note in the DAC troubleshooting section for users who are directed there from an error regarding additionally_allowed_tenants configuration. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [Storage] Fix docs for `list_blobs` and `walk_blobs` (#26836) * [ML] Enable SDK data and datastore get calls to use new error message format (#26788) * enable SDK data and datastore get calls to use new error message format * Add registry delete operation (#26751) * initial delete files * delete swagger and autorest corrections * change delete param name * update recordings and e2e test * add changelog line * fix op return comments, make test require error on last op * remove unneeded variable declaration * Add else schema type value (#26858) * [Storage] Fix failing pipeline tests (`test_share.py`) + `name_starts_with` async bug fix (#26793) * Add playback only tag to failing live tests * Refactored to hopefully get rid of conflicts * Tests should pass now, fix prefix bug * Re-record test to fix CI * [Storage] Fix `isodate` dependency (#26874) * Add playback only tag to failing live tests * Refactored to hopefully get rid of conflicts * Tests should pass now, fix prefix bug * Re-record test to fix CI * Fix isodate dependency issue * remove msrest dependency introduced by merging main * one last fix * [Storage] Fix content range check for empty files (#26872) * skipping flaky bp test for now (#26829) * [EventHubs] exception/kwargs testing (#26867) * fix flushing list batches in bp * add send list bp test * Added test cases for Azure load testing management plane (#26842) * added sdk tests * removed recorded_by_proxy * updated test proxy setup as per recommendation * Update conftest.py * Update ci.yml * Update ci.yml Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-nginx-2022-10-13-60502(Do not merge) (#26796) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * [AutoRelease] t2-avs-2022-10-13-52806(Do not merge) (#26798) * code and test * Update CHANGELOG.md * Update CHANGELOG.md * Update _version.py Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-containerservice-2022-10-12-83343(Do not merge) (#26774) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Support e2e run for if_else node in pipeline (#26780) * add e2e test * update test * fix test * fix pipeline tests * add comment * fix test * merge swagger pipeline into one (#26846) * code * code * feat: avoid serialize input value from int string to float (#26878) * fix: avoid serialize input value from int string to float * fix: fix ci * fix: pylint * [ML][Pipelines] avoid changing base_path in validation (#26851) * feat: add base path to path field validation error message * refactor: avoid creating temp folder when not necessary * feat: skip path validation if with additional includes * fix: pylint * fix: fix bandit * fix: resolve internal environment based on local code * Update setup.py (#26875) * [CLU] regen on 2022-10-01-preview for runtime (#26233) * regenerate on 2022-10-01-preview for CLU runtime * add rest api docs to the docstrings * remove patched docstrings for authoring, swagger transform now works to include rest api docs * use swagger transforms to edit docs instead of patch * regen runtime/authoring now that specs are in main * rerecord and fix doc * add separation between doc comment and link * Fix code snippet in README (#26879) * Migrate Attestation tests to test proxy (#26220) * Update auto-gen code for 2022-10-01-preview API version (#26873) * Update autorest code for 2022-10-01-preview API version * [Core/OpenTelemetry] Fixed spelling errors (#25610) * fix: typo, cspell config * fix: second typos * cspell: move inline to cspell.json Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> * Remove mgmt azure-sdk-tools reqs ***NO_CI*** * Change default local storage location (#26891) * code and test (#26908) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Update swagger_to_sdk_config_dpg.json (#26913) * feat: enable internal components in pipeline yaml (#26800) * feat: enable internal components in pipeline yaml * refactor: add some gate logic * fix: fix test_pipeline_job_create_with_registries * fix: fix pylint * Cadl automation pipeline (#26912) * cdoe * fix * code * fix * code * meta.json * meta.json * compatible * refactor: divide pipeline related tests (#26886) * fix: sdk.ml.azure-ai-ml.tests.datastore.e2etests.test_datastore * feat: component with default label * refactor: divide test_dsl_pipeline.py * feat: load labelled arm id * feat: support name@default use name@label for node component in pipeline yaml * [TA ] improve per-document error message when all documents fail per action (#26902) * fix bad Document error message when all actions fail * update changelog * update wording * skip cosmos emulator (#26930) * try 3.7 * skip cosmos emulator tests until fixed * revert change * comment out emulator * fix ci for core (#26923) * fix ci for core * updates * updates * updates * updates * updates * adding additional version override support * update * update * update * update conda test-requirements to include azure-mgmt-storage that was previously coming dependency tools/azure-sdk-tools Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Fix py.typed verification script (#26626) In order to ensure that a py.typed file is packaged with both source and binary distributions of a package, we have a script that verifies various configurations. This script had a bug that would validate a package as passing as long as the MANIFEST.in file was correctly configured, disregarding issues in the setup.py file. This fixes the issue and updates pertinent impacted setup.py files. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [formrecognizer] Skip errors in live tests (#26649) * add more error cases to skip decorator * update last case to catch invalidimage errors * recoveryservices pin (#26935) * Add Azure DevCenter Package (#26696) * Add generated code * Add samples * Add test coverage * Recordings * Add defaults for test env variables * autorest, cspell, and shared reqs * Add readme items * Update to use testproxy * Work around issue * Update CI * Fix up tests to use kwargs * Add extra sanitizers, fix readme casing * Rerun with fresh container image * Whitelist pylint failure * Unblock * Update sdk/devcenter/azure-developer-devcenter/README.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update samples/readme * Update shared_requirements.txt Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [formrecognizer] Fix logging test to take into account new header (#26937) * allow x-ms-region to be logged * add async client * [AutoRelease] t2-resource-2022-10-18-32015(Do not merge) (#26885) * code and test * version * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * fix (#26943) * upgrade node verstion (#26944) * upgrade node * node verstion * temporality (#26924) * Fix example link (#26810) * Re-arrange imports and experimental tags to prevent warnings on unrelated operations (#26892) * change imports to avoid extra experimental warnings * add tag to merged functon * cl * add experimental tag to registry property * Remove requests dependency from PyPIClient (#26954) * remove requests dependency from PyPIClient in favor of urllib3 * update tox packaging dependency with urllib3 * add urllib3 to azure-sdk-tools requirements * [ML] Add Team Ownership Markers to Test Classes (#26957) * Add markers to test classes * add untracked changes * Change default storage retention period to 48 hrs (#26960) * azure-developer-loadtesting v1.0.0b2 (#25550) * SDK generated autorest * upload function added * patch.py changed * upload updated * whl file removed * whls deleted * aio updated * spell check added * spell check * Update shared_requirements.txt * Update MANIFEST.in Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update setup.py Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * spell added * patch.py updated * linting corrected * Update allowed_pylint_failures.py * readme updated * patch.py updation * Update _patch.py * tests added * async naming * test and result * push the test result * fix * fix * tests added and async built * yaml added * yaml updated * sample and readme updated * fix ci.yml * more tests and samples addded and readme updated * tests * fix * fix2 * type added * type added * Update CHANGELOG.md * chnaged to developer * renamed package * chnaged ci files * linting fixes * changed namespace from analytics to developer * app_component naming cleaned * folded get_app_component * various name changes and added type hinting * lint changes * added wrapper for LoadTestClient * removed msrest dependencies * corrected Serializer method * test_smoke fixed * fixes in aio class * updates samples * namespace chg AppComponent, serverMetrics, test * updated samples * namespace changes done * LoadTestClient -> LoadTestingClient * apnd load_test to test_run & adminstration * added Readme Descirption * few changes in tests * moved SUBSCRIPTION_ID to .env * resloved readme issues by @iscai-msft in #24744 * resolved #discussion_r925248158 * resolving other issue by @iscai-msft #24744 * #25264#discussion_r925284462 * cleaned tests * namechanges * resolved folding issues * fixing dependencies verison * added tests for _patch(es) * removed subs id from recordings * fixing isodate requirements * removed SaaS key from smoke test * folder name chnage + setup.py cleaned * Readme changes suggested by @msyyc * added dependencies in shared_requirements.txt * removed os.environ from tests * liniting * removed async test * fixing tests * ci fix try * trying dev_tools * fix for azure-mgmt-loadtestservice dev_reqs * added async tests * some tests * cleaned setup * fixing async tests * added mgmt to loadtestservice to ci * changed fie mode from json to BinaryIO * reverting merge by @BigCat20196 * removed TEST_ID * solving issues by @lmazuel * update with autorest6.1.0 and update tests * update and format * fix playback failed * Update test_smoke.test_create_or_update_test_run.yaml * Update test_smoke.test_smoke_create_or_update_test.yaml * Update test_smoke_async.test_smoke_create_or_update_test.yaml * updated README * test case of app components create * delete_app_components fixed * complete testing for AppComponent Class * tested create_or_update_test * client.load_test_administration.delete_load_test * tests for get_load_test * tested upload_test_file * complete TestOperations testing * removed sas keys from recordings * corrected name error * corrected sample and added tests for test_run(1/2) * TestRun testing done * completed ServerMetrics testing * remove SAS key from files * removing SAS key * Update README.md * Update README.md * Update README.md * Update README.md * some work in tests * cleaned samples as per @ninallam * updated CHANGELOG.md * updated CHANGELOG.md * trying to fix chnagelog CI * migrate tests to testproxy * added changes suggested by @ninallam & @msyyc * updated change log * Update README.md * fixed issues with sample * fix playback failed * Update sdk/loadtestservice/azure-developer-loadtesting/CHANGELOG.md * Update CHANGELOG.md * fix playback failed * Fix changelog * Update _version.py * Update CHANGELOG.md * added bug explanation in Readme file. * removed samples and test cases from Changelog * added resource creation example in samples for mgmt plane * fixed sample resource creation link * adding ref to DefaultAzureCredential * refactor mgmt sample file * broken samples into files * fixed samples as disucssed with @iscai-msft * added few access to reult dict * update tests and recordings * Update README.md * fixed typo, matrics -> metrics * fixed typo, matrics -> metrics * update test recording * rename non test files * improved samples as per @ninallam * simplified check validation in SDK * resolved comments by @iscai-msft * pushing new design for validation checking * minor changes * removed LRO operations * minor fixes * started async tests * pushing more tests * completed corresponding async tests * removed mgmt plane samples * fixing broken link * ran black * chnaged security scope * Update CHANGELOG.md * Update conftest.py * updated README * added troubleshooting section * minor fixes Co-authored-by: Yashika Jain <t-yjain@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Yashika Jain <70585531+Yashikaj14@users.noreply.github.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com> Co-authored-by: Nivedit Jain <jain.22@iitj.ac.in> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: BigCat20196 <1095260342@qq.com> Co-authored-by: Nikita Nallamothu <50437471+ninallam@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 3790 (#26927) * Added yaml support for job matrix creation * autogen scenario matrix for stress test * Temporary Working State * update to default sparse * pr comments and some error handling * custom matrixfilename and ordering of generatedValues.yaml * common module import * JobMatrix write host Co-authored-by: Albert Cheng <albertcheng@microsoft.com> * [EH] perf pipeline configuration (#26866) * Added EH perf resources * Added perf yml * Fix env var name * Add AZURE_EVENTHUB_NAME * Improve bicep * Align eventhub name with test-resources.json * Eliminate unnecessary variables Co-authored-by: Mike Harder <mharder@microsoft.com> * add a default of 3 retries to PyPIClient (#26963) * Resolve SSL Cert Failures in CI (#26965) * add optional ca_certs arg to urllib3 connection pool to ensure that ubuntu tests are not broken by the requests -> urllib3 swap * [ML][Pipelines] Validate invalid scenario: control flow node as init/finalize (#26918) * validate control flow node as init/finalize * fix if logic order * fix pylint issue for trailing whitespace * remove unused parameter for test * [AutoRelease] t2-elasticsan-2022-10-21-29939(Do not merge) (#26970) * code and test * generated samples Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * [AutoRelease] t2-cdn-2022-10-21-12465(Do not merge) (#26971) * code and test * version * samples Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * [Cadl pipeline] optimize the recording about codegen version (#26969) * version * optimization * capture details when returned (#26962) * [CLU] update sample/tests with role for conv summ (#26956) * fix how we passed in summaryAspects * skip tests and samples due to service regression * missed async * account for role * Adding code owners for ML Ops and ML Inference (#26981) * owners * owners * owners * inference owners * [Maps] Add 'include_package_data' field to setup (#26936) A recent fix to the py.typed verification script that is called in the CI now fails if the field 'include_package_data' does not exist or does not equal 'True' in a package's setup.py. This adds this file to recently onboarded packages that did not have this. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Upgrade cspell packages to version `^6.12.0` (#26985) to address dependabot issue https://github.com/Azure/azure-sdk-for-js/security/dependabot/13 Co-authored-by: Jeremy Meng <yumeng@microsoft.com> * [chore] Remove CI for unmaintained packages (#26961) ApplicationInsights and LogAnalytics date-plane packages are no longer being maintained and the nightly CI continually fail for these. Here, the CI configuration is altered to stop testing the data-plane packages. Control-plane (mgmt) package testing will still remain. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Support Model in registry in pipeline (#26914) * update * skip Co-authored-by: Ying Chen <2601502859@qq.com> * [AutoRelease] t2-cognitiveservices-2022-10-19-45579(Do not merge) (#26904) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * Sync eng/common directory with azure-sdk-tools for PR 4480 (#26992) * Add extra parameters for .net readme path * Use another way for default value * Remove custom source Co-authored-by: sima-zhu <sizhu@microsoft.com> * code and test (#26996) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * [ML][Pipelines] dsl.pipeline support pass non_pipeline_parameters (#26920) * support non_pipeline_parameters * fix test case * support non_pipeline_parameters * fix comment * fix code style * fix test case * fix test case * fix test case * fix comment * fix test case * fix comment * code and test (#26998) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Support identity in pipeline node (#26975) * support identity in node * add test * update * fix pylint error * fix test * [BOTRULES] ML changes (#26989) * [BOTRULES] ML changes Matching changes from #26981 * Update .github/fabricbot.json Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> * [Test Proxy] Improved logging and timeout behavior (#26903) * remove warning (#26990) * add skip flaky test decorator to FRC and FTC tests (#27010) * Split ML livetest configurations (#27009) * commit initial restructure, pushing to upstream, will stand up a single environment before merging * add unknown word to cspell list so it doesn't yell at us * [ML] Re-enable sdk logging (#26877) * Re-enable logging with opencensus * Add tests back * Fix import and change variable names * Add pylint disable for abstract class, add logger, and fix pylint error * Add check for jupyter notebook * remove comment * Move jupyter check to get_appinsights_log_handler * Move jupyter check to get_appinsights_log_handler * Update ops_logger.update_info in code and component operations * fix circular import and pylint errors * Move in_jupyter_notebook * Update docstring * Rename logger attribute to package_logger * Update OpsHandler logger attribute to package_logger * Update README telemetry section * Refactor telemetry_collection_disabled * Fix pylint * Add test for telemetry disabling * [Storage] Fix duplicate sample tag in `blob_samples_authentication.py` (#26929) * Fixed duplicate sample tag, added missing sample to async + unify samples to match more closely * Add function call to newest sample in async * Removed uncomment comment * [Storage] Merge hotfix branch into `main` (#26910) * [ML][Pipelines]test: shorten test name to enable recording (#26995) * feat: shorten test name to enable recording * fix: fix ci * Support properties in command component (#27000) * support properties * remove properties if not specified * remove properties in post dump * Separate jobs from schema load (#27019) Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Brynn Yin <biyi@microsoft.com> * code and test (#27018) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Fix Pylint warnings for the new checkers (#26269) * Updating CODEOWNERS for common and identity (#27020) * updating codeowners for common and identity * updating codeowners with generic folder on top * fix registry managed tags (#26977) * fix registry managed tags * add testing * remove trailing whitespace * add in-line comments explaining tags * pylint pass * update swagger to match other tags exactly * Update README.md (#27027) * [ML] Add Code Owners for Split ML Test Pipelines (#27026) * [ML] Add Code Owners for Split ML Test Pipelines * fix missing entry * add scott * Update environment.py (#27005) * Update environment.py Not setting this object (environment._translated_conda_file) causes a mismatch between the registered env and the loaded one which leads to re-register the existing env. This issue only happens with environment that includes conda file. * Update sdk/ml/azure-ai-ml/azure/ai/ml/entities/_assets/environment.py Co-authored-by: Man <43016276+Man-MSFT@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Man <43016276+Man-MSFT@users.noreply.github.com> * [Bot Rules] Update ML pull request labels (#27028) The focus of these changes is to update the pull request labels for ML paths to incorporate the changes from #27026. * [AppConfig] Fix pipeline failures (#26907) * [ML] Restrict JobServiceType to jupyter_lab, ssh, tensor_board, vs_code and perform required conversion before sending to rest API (#26863) * [ML] Validate the values of JobService.job_service_type passed to Command() and use snake_case * Fix types list * Fix tests * Update changelog.md * [Test Proxy] Documentation updates and improvements (#27036) * [Identity] Add more detail to VSCodeCred class doc (#27013) Add more details to the VisualStudioCodeCredential class docstring to let users know about its current shortcomings. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [formrecognizer] Fix readme link (#27043) * fix readme link * remove locale * Update autorest.python to `6.2.1` for new feature `--generate-sample` (#26940) * Update swagger_to_sdk_config_autorest.json * Update swagger_to_sdk_config_autorest.json * Update swagger_to_sdk_config_autorest.json * Update setup.py * optimize dependency * optimize dependency * optimize dependency * optimize dependency * [ML][Pipelines]feat: anonymous component reuse (#27008) * feat: internal anonymous component reuse - basic need to test ignore file & additional includes * fix: resolve comments * fix: fix pylint & ci * test: update internal pipeline job tests recording * fix: fix ci * fix: fix ci * fix: skip some tests in recording mode to pass ci * [NetAppFiles] T2 netapp 2022 10 14 81282 (#26978) * code and test * Update CHANGELOG.md * Update _version.py * update test recordings * update test recordings2 * update sanitizer * update test recording pool * remove commented line * update test files * add mgmt to dev-requiremetns * update test files * update test file * rerun 2 test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Support Parallel Run Step partition by keys (#26844) * v1 * fix lint * pass through partition keys * marshal and unmarshal the partition keys in the parallel component * e2e test passed * add parallel component partition keys UT * add test case * fix UT * fix lint * fix e2e * fix UT * recording * recording twice * add comments * recording * fix recording * fix crlf to lf * skip under none live mode * update recording * fix comment * fix lint * fix ut * import json Co-authored-by: Xiaole Wen <xiwe@microsoft.com> Co-authored-by: Clement Wang <clwan@microsoft.com> * [Identity] Fix issue with cache option usage (#27030) If a user supplies `TokenCachePersistenceOptions` to a `SharedTokenCacheCredential`, these options are not used when the cache is loaded. This can lead to issues when users are trying to use caches with custom names since the default name is used instead. This commit ensures that user-provided cache options are propagated when the cache is loaded. Ref: #26982 Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Improve scenario matrix edge case handling (#27070) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Fix #26857: separate stdout from stderr in AzureCliCredential (#26953) * Fix #26857: separate stdout from stderr in AzureCliCredential * Fix unit tests for AzureCliCredential * Fix #26857 for aio.AzureCliCredential * azure_cli.py: Fix types in _run_command * Fix test_cli_credential_async.py * Update sdk/identity/azure-identity/CHANGELOG.md Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> * make registry delete return an lro poller (#26983) * make registry delete reutrn lro poller * cleanup * change operation name to begin_delete * sleep long enough to dodge ev issues in testing * move CL line to breaking changes * further refine delete swagger, edit docstrings * review comments * add reliability notice * Add test proxy setup instructions to `dev_setup.md` (#27081) * update changelog and version (#27069) * update changelog and version * Fix #26857: separate stdout from stderr in AzureCliCredential (#26953) (#27076) * Fix #26857: separate stdout from stderr in AzureCliCredential * Fix unit tests for AzureCliCredential * Fix #26857 for aio.AzureCliCredential * azure_cli.py: Fix types in _run_command * Fix test_cli_credential_async.py * Update sdk/identity/azure-identity/CHANGELOG.md Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: maowtm <micromaomao@gmail.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * update Co-authored-by: maowtm <micromaomao@gmail.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * update changelog for release (#27080) * update changelog (#26860) * update changelog * update * Fix online deployment and batch deployment documentation (#27086) Co-authored-by: Nancy Mejia Juarez <namejia@microsoft.com> * Increment package version after release of azure-ai-textanalytics (#27095) * [Storage] Migrate `test_queue_client.py` to test proxy (#27039) * Live sync finally passing * Finished async * Remove async ignore Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Xingzhi Zhang <37076709+elliotzh@users.noreply.github.com> Co-authored-by: Alex Tsao <alextts627@gmail.com> Co-authored-by: Maxim Rytych <99686729+maximrytych-ms@users.noreply.github.com> Co-authored-by: Aigerim Beishenbekova <aigerimb@microsoft.com> Co-authored-by: jeff-shepherd <39775772+jeff-shepherd@users.noreply.github.com> Co-authored-by: MilesHolland <108901744+MilesHolland@users.noreply.github.com> Co-authored-by: Diondra <16376603+diondrapeck@users.noreply.github.com> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: Harneet Virk <harnvir@microsoft.com> Co-authored-by: zhenbiao wei <424401670@qq.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Daniel Ortega <96089426+danielortega-msft@users.noreply.github.com> Co-authored-by: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com> Co-authored-by: sima-zhu <sizhu@microsoft.com> Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> Co-authored-by: Brynn Yin <24237253+brynn-code@users.noreply.github.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: Matt Metcalf <mrm9084@gmail.com> Co-authored-by: Yulin Li <liyulin@pku.edu.cn> Co-authored-by: Yulin Li <Yulin.Li@microsoft.com> Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Co-authored-by: Clement Wang <47586720+wangchao1230@users.noreply.github.com> Co-authored-by: Clement Wang <clwan@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: David Davis <daviddavis@users.noreply.github.com> Co-authored-by: Venkat Ragavan <50309787+venkatr21@users.noreply.github.com> Co-authored-by: Han Wang <phoenix.seek@gmail.com> Co-authored-by: Pramod Valavala <43602528+PramodValavala-MSFT@users.noreply.github.com> Co-authored-by: nishuvats2009 <111009925+nishuvats2009@users.noreply.github.com> Co-authored-by: Hanchi Wang <luigiking307@gmail.com> Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com> Co-authored-by: mccoyp <mcpatino@microsoft.com> Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com> Co-authored-by: chrissmiller <chris.20@dartmouth.edu> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> Co-authored-by: Nivedit Jain <niveditjain@microsoft.com> Co-authored-by: Yashika Jain <t-yjain@microsoft.com> Co-authored-by: Yashika Jain <70585531+Yashikaj14@users.noreply.github.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com> Co-authored-by: Nivedit Jain <jain.22@iitj.ac.in> Co-authored-by: BigCat20196 <1095260342@qq.com> Co-authored-by: Nikita Nallamothu <50437471+ninallam@users.noreply.github.com> Co-authored-by: Albert Cheng <albertcheng@microsoft.com> Co-authored-by: Anna Tisch <antisch@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com> Co-authored-by: Banibrata De <banibrata@outlook.com> Co-authored-by: Jeremy Meng <yumeng@microsoft.com> Co-authored-by: Ying Chen <chenyin@microsoft.com> Co-authored-by: Ying Chen <2601502859@qq.com> Co-authored-by: lalala123123 <henu_rz@163.com> Co-authored-by: Ronnie Geraghty <rgeraghty@microsoft.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Olena Stoliarova <110589094+ostoliarova-msft@users.noreply.github.com> Co-authored-by: Muna-alhassan <63193120+Muna-alhassan@users.noreply.github.com> Co-authored-by: Man <43016276+Man-MSFT@users.noreply.github.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: TonyJ1 <41344586+TonyJ1@users.noreply.github.com> Co-authored-by: Auðunn <audunnb@gmail.com> Co-authored-by: xiaolewen <xiaole.wen@bupt.edu.cn> Co-authored-by: Xiaole Wen <xiwe@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: maowtm <micromaomao@gmail.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: nancy-mejia <106106141+nancy-mejia@users.noreply.github.com> Co-authored-by: Nancy Mejia Juarez <namejia@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For more information, please check out the issue
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines