Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy startup improvements #26758

Open
4 tasks
scbedd opened this issue Oct 11, 2022 · 1 comment
Open
4 tasks

Proxy startup improvements #26758

scbedd opened this issue Oct 11, 2022 · 1 comment
Assignees
Labels
EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative. test-enhancement
Milestone

Comments

@scbedd
Copy link
Member

scbedd commented Oct 11, 2022

I am adding a couple other items that I am seeing while exploring the requirements.

  • When initializing, attempt to start the container using podman before using the heavier and more error-prone docker.
  • We can remove the code targeting different versions
    • The correct repo to use (now that we publish a multiplatform issue) is engsys/test-proxy. The tagging method based off file should stay.
    • We no longer publish a windows image, as we no longer support docker in CI. Better to just rip this out entirely.
  • Allow optional auto-detection + passing on to the docker initialize of a couple environment variables.
    • GIT_COMMIT_OWNER
    • GIT_COMMIT_EMAIL
    • GIT_TOKEN
    • Here is an example of passing environment variables to docker/podman.
  • We should add a timeout of 1 minute to all proxy interactions. If we time out, we should give a recognizable "I can't talk to the test proxy for some reason" error. Currently we just hang if there is a proxy communication failure.

I think these are the high points.

@scbedd scbedd added the EngSys This issue is impacting the engineering system. label Oct 11, 2022
@github-actions github-actions bot added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Oct 11, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'azure-spring:0.18326132,Azure.Core:0.10056478,Storage:0.098949455'

@xiangyan99 xiangyan99 removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Oct 11, 2022
@scbedd scbedd changed the title Test Framework includes podman in startup attempts Proxy startup improvements Oct 11, 2022
@mccoyp mccoyp added this to the 2022-12 milestone Nov 15, 2022
@mccoyp mccoyp added the MQ This issue is part of a "milestone of quality" initiative. label Dec 5, 2022
@mccoyp mccoyp modified the milestones: 2022-12, 2023-01 Dec 5, 2022
@mccoyp mccoyp modified the milestones: 2023-01, 2023-02 Jan 10, 2023
@mccoyp mccoyp modified the milestones: 2023-02, 2023-03 Feb 23, 2023
@mccoyp mccoyp modified the milestones: 2023-03, 2023-04 Mar 14, 2023
@mccoyp mccoyp modified the milestones: 2023-04, 2023-05 Apr 11, 2023
@mccoyp mccoyp modified the milestones: 2023-05, Backlog May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative. test-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants