Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualMachinesOperations.get() takes 3 positional arguments but 4 were given #30983

Closed
RyanMesser opened this issue Jul 1, 2023 · 10 comments · Fixed by ClusterLabs/fence-agents#562
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-author-feedback More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@RyanMesser
Copy link

  • Package Name: azure-mgmt-compute
  • Package Version: 30.0.0
  • Operating System: Ubuntu 22.04 LTS on Azure
  • Python Version: 3.10.6

Describe the bug
A clear and concise description of what the bug is.

When running fence_azure_arm --msi --plug=host --action=status (or any other action) the following error is recieved
VirtualMachinesOperations.get() takes 3 positional arguments but 4 were given

If I install version 29.0.0 this issue isn't present, not sure if bug or missing information that is needed.

To Reproduce
Steps to reproduce the behavior:

  1. ssh/cli to Ubuntu host
  2. Run above fence_azure_arm command and error is seen
  3. Other than status the action doesn't complete

Expected behavior
A clear and concise description of what you expected to happen.
For actions such as "off" and "reboot" the host to reboot or stop

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 1, 2023
@kashifkhan
Copy link
Member

Thank you for the feedback @RyanMesser . We will investigate and get back to you asap.

@kashifkhan kashifkhan added Mgmt This issue is related to a management-plane library. and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Jul 5, 2023
@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label Jul 5, 2023
@msyyc
Copy link
Member

msyyc commented Jul 6, 2023

Hi @RyanMesser I think your error is related with expand that is changed from positional argument to keyword-only argument since expand is query parameter. It can be fixed by:

...
client.virtual_machines.get(..., expand="xxx")

image

@RyanMesser
Copy link
Author

Hi @RyanMesser I think your error is related with expand that is changed from positional argument to keyword-only argument since expand is query parameter. It can be fixed by:

...
client.virtual_machines.get(..., expand="xxx")

image

Is this a fix you're going to release or is this something i need to do manually on each host?

@msyyc
Copy link
Member

msyyc commented Jul 7, 2023

You need to do it manually.

@xiangyan99 xiangyan99 added the issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. label Jul 7, 2023
@github-actions github-actions bot removed the needs-team-attention This issue needs attention from Azure service team or SDK team label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Hi @RyanMesser. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

@github-actions
Copy link

Hi @RyanMesser, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.

@RyanMesser
Copy link
Author

/unresolve

I think more information is needed for this as I don't feel it really awnsers the question or provides enough context for the awnser.

Hi @RyanMesser, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.

@github-actions github-actions bot reopened this Jul 14, 2023
@github-actions github-actions bot added needs-team-attention This issue needs attention from Azure service team or SDK team and removed issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. labels Jul 14, 2023
@msyyc
Copy link
Member

msyyc commented Jul 24, 2023

@RyanMesser, Is your source code here? https://github.com/ClusterLabs/fence-agents/tree/main
If so, you just need to change this line to

vmStatus = compute_client.virtual_machines.get(rgName, vmName, expand="instanceView")

or open issue for the tool developer to fix it.

@xiangyan99 xiangyan99 added the needs-author-feedback More information is needed from author to address the issue. label Jul 28, 2023
@github-actions github-actions bot removed the needs-team-attention This issue needs attention from Azure service team or SDK team label Jul 28, 2023
@github-actions
Copy link

Hi @RyanMesser. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Hi @RyanMesser, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Aug 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-author-feedback More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants