Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-cosmos CosmosClient.query_databases "parameters" argument incorrect typing #31811

Closed
Lee-W opened this issue Aug 25, 2023 · 2 comments
Closed

azure-cosmos CosmosClient.query_databases "parameters" argument incorrect typing #31811

Lee-W opened this issue Aug 25, 2023 · 2 comments
Assignees
@simorenoh
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Lee-W
Copy link

Lee-W commented Aug 25, 2023

  • Package Name: azure-cosmos
  • Package Version: 9.2.0
  • Operating System: mac OS
  • Python Version: 3.10.6

Describe the bug
Type inconsistency between https://github.com/Azure/azure-sdk-for-python/blob/azure-mgmt-cosmosdb_9.2.0/sdk/cosmos/azure-cosmos/azure/cosmos/cosmos_client.py#L389 and https://github.com/Azure/azure-sdk-for-python/blob/azure-mgmt-cosmosdb_9.2.0/sdk/cosmos/azure-cosmos/samples/database_management.py#L41-L46.

To Reproduce.

Expected behavior
The type of https://github.com/Azure/azure-sdk-for-python/blob/azure-mgmt-cosmosdb_9.2.0/sdk/cosmos/azure-cosmos/azure/cosmos/cosmos_client.py#L389 should be list[dict[str, Any]] instead

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-triage This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 25, 2023
@kristapratico kristapratico removed the needs-team-triage This issue needs the team to triage. label Aug 25, 2023
@kristapratico
Copy link
Member

Hi @Lee-W thanks for your feedback, we'll take a look and get back to you soon.

@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label Aug 25, 2023
@simorenoh simorenoh mentioned this issue Aug 29, 2023
Merged
@simorenoh
Copy link
Member

@Lee-W Thank you for pointing this out, you are correct. We have pushed the changes for this now in the PR referenced. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@simorenoh simorenoh

Labels
Client This issue points to a problem in the data-plane of the library. Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lee-W @simorenoh @kristapratico