Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartionKey and/or RowKey dropped for empty string #31920

Closed
gr-rob opened this issue Sep 1, 2023 · 4 comments
Closed

PartionKey and/or RowKey dropped for empty string #31920

gr-rob opened this issue Sep 1, 2023 · 4 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. Tables

Comments

@gr-rob
Copy link

gr-rob commented Sep 1, 2023

PartitionKey and RowKey will be dropped if their value is an empty string as an empty string is evaluated as False by Python.

161 and 166 should explicitly check for None value:

# Partition key is a known property
partition_key = properties.pop("PartitionKey", None)
if partition_key is not None:
    entity["PartitionKey"] = partition_key

# Row key is a known property
row_key = properties.pop("RowKey", None)
if row_key is not None:
    entity["RowKey"] = row_key
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-triage This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables labels Sep 1, 2023
@kashifkhan
Copy link
Member

Thank you for the feedback @gr-rob . We will investigate and get back to you asap.

@kashifkhan kashifkhan removed the needs-team-triage This issue needs the team to triage. label Sep 1, 2023
@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label Sep 1, 2023
@YalinLi0312
Copy link
Member

Hi @gr-rob , we have fix it in the latest release 12.4.4 which just published today: https://pypi.org/project/azure-data-tables/ Please give it a try and let us know any further issues.

@YalinLi0312 YalinLi0312 added the issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. label Sep 14, 2023
@github-actions
Copy link

Hi @gr-rob. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

@github-actions github-actions bot removed the needs-team-attention This issue needs attention from Azure service team or SDK team label Sep 14, 2023
@github-actions
Copy link

Hi @gr-rob, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.

@YalinLi0312 YalinLi0312 added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. Tables
Projects
None yet
Development

No branches or pull requests

3 participants