Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-monitor-ingestion: add input type check for logs #32681

Closed
adalli13 opened this issue Oct 24, 2023 · 2 comments
Closed

azure-monitor-ingestion: add input type check for logs #32681

adalli13 opened this issue Oct 24, 2023 · 2 comments
Assignees
@pvaneck
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@adalli13
Copy link

adalli13 commented Oct 24, 2023 •
edited

Is your feature request related to a problem? Please describe.
I have been troubleshooting why my logs do not arrive in my destination in LogAnalytics Workspace, even though there was no error. At the end, my error was that my input for the logs argument in LogIngestionClient.upload() was a dict instead of a list.

Describe the solution you'd like
It would be nice to raise an error if the logs input has a wrong type.

Alternative solution
Alternatively, it could also be a solution to allow a dictionary and a list as input for logs.
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 24, 2023
@xiangyan99 xiangyan99 added Monitor Monitor, Monitor Ingestion, Monitor Query Client This issue points to a problem in the data-plane of the library. and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Oct 24, 2023
@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label Oct 24, 2023
@xiangyan99
Copy link
Member

Thanks for the feedback, we’ll investigate asap.

@pvaneck
Copy link
Member

pvaneck commented Oct 24, 2023

Hey, @adalli13. Nice timing. This was actually just added not too long ago: #32591. A new release will be cut early November.

As a side note, the service team for Azure Monitor has been working on adding DCR diagnostic logs for logging error messages when a malformed payload is received. This will also be visible to the user. This feature is currently in private preview, but will likely GA by the end of the year.

Hopefully, both these changes will improve the user experience.

@pvaneck pvaneck closed this as completed Oct 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pvaneck pvaneck

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pvaneck @xiangyan99 @adalli13