Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[corehttp] corehttp SansIOHTTPPolicy is not compatible with existing credentials that use azure.core SansIOHTTPPolicy #34285

Closed
swathipil opened this issue Feb 12, 2024 · 0 comments · Fixed by #34296
Labels
Client This issue points to a problem in the data-plane of the library. Core.Http

Comments

@swathipil
Copy link
Member

The corehttp Pipeline should accept currently existing Azure credential policies (and others). However, many of these inherit from azure.core SansIOHTTPPolicy. As a result, the policy isn't appended to the SansIOHTTPPolicyRunner b/c of this isinstance check which checks against the corehttp SansIOHTTPPolicy. If we instead make corehttp SansIOHTTPPolicy a runtime_checkable Protocol, the existing credentials should work.

@swathipil swathipil added Client This issue points to a problem in the data-plane of the library. Core.Http labels Feb 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Core.Http
Projects
None yet
1 participant