Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracing] Add URI query parameter sanitization #35372

Open
pvaneck opened this issue Apr 25, 2024 · 2 comments · May be fixed by #35546
Open

[Tracing] Add URI query parameter sanitization #35372

pvaneck opened this issue Apr 25, 2024 · 2 comments · May be fixed by #35546
Assignees
@pvaneck
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-attention This issue needs attention from Azure service team or SDK team

Comments

@pvaneck
Copy link
Member

pvaneck commented Apr 25, 2024

By default, the url.full HTTP span attribute contains no sanitization. We should change the default to sanitize all query parameters that do not fall into some allow list.

Example: https://server:port/path/a/b/c?foo=REDACTED&bar=REDACTED&api-version=1.2.34

This "allow list" for query parameters should also be configurable by users. The HttpLoggingPolicy does have a allowed_query_params field, but this does not appear to be getting any use. Something similar could be employed to allow user customization.
@pvaneck pvaneck self-assigned this Apr 25, 2024
@github-actions github-actions bot added Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-attention This issue needs attention from Azure service team or SDK team labels Apr 25, 2024
@github-actions GitHub Actions
Copy link

@kashifkhan @xiangyan99

@github-actions GitHub Actions
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@pvaneck pvaneck linked a pull request May 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvaneck pvaneck

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-attention This issue needs attention from Azure service team or SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Sanitize query params in url tracing attribute pvaneck/azure-sdk-for-python
2 participants
@pvaneck @xiangyan99