Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests in each sdist #4412

Closed
jayvdb opened this issue Feb 25, 2019 · 3 comments
Closed

Include tests in each sdist #4412

jayvdb opened this issue Feb 25, 2019 · 3 comments

Comments

@jayvdb
Copy link

jayvdb commented Feb 25, 2019

As there is no plan to distribute a single meta package (c.f. #815), please include tests in each sdist.

Otherwise each openSUSE package needs to add a copy of the entire repo in its staging area in order to find and use the appropriate tests.

It should be only a matter of adding tests/ to each MANIFEST.in, and updating any templates so new packages also get this right, but it might also require adding other directories if test data isnt located under tests/.

Ideally also ensure that python setup.py test in each sdist runs the tests, doing any prep required.

@jayvdb
Copy link
Author

jayvdb commented Feb 25, 2019

It would also be nice to have separate changelogs in each sdist.

Having to get it from GitHub is annoying.

Either I need to clone a large repo to get the tags, scroll through pages at https://github.com/Azure/azure-sdk-for-python/releases/, or guess it for a package, and in this case I failed to guess it based on apparent tag naming conventions https://github.com/Azure/azure-sdk-for-python/releases/tag/azure-storage-common_1.4.0 is 404

@lmazuel
Copy link
Member

lmazuel commented Mar 1, 2019

Hi @jayvdb
I wanted to check the Python guidelines before coming to you, and you're right, tests should be in the sdist:
https://docs.python.org/2/distutils/sourcedist.html#principle

Regarding the ChangeLog, it's already inside and named HISTORY.rst (we are moving to HISTORY.md since now PyPI supports Markdown)

@lmazuel
Copy link
Member

lmazuel commented Mar 1, 2019

Hi @jayvdb
I merge my MANIFEST template that I use for all packages, new packages starting now will have tests inside.
Thanks for the report!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants