Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request builder future is not Send #113

Closed
MindFlavor opened this issue Dec 4, 2020 · 2 comments · Fixed by #114
Closed

Request builder future is not Send #113

MindFlavor opened this issue Dec 4, 2020 · 2 comments · Fixed by #114
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@MindFlavor
Copy link
Contributor

As correctly noted by Ben Sully in #112, not using a let binding in request builders makes futures not Sendable.

The PR fixes one builder but we should extend the fix to all the other builders.
@MindFlavor MindFlavor added feature-request This issue requires a new behavior in the product in order be resolved. Client This issue points to a problem in the data-plane of the library. labels Dec 4, 2020
@MindFlavor MindFlavor mentioned this issue Dec 4, 2020
Merged
@extrawurst
Copy link
Contributor

@MindFlavor Yeah I just ran into this for the PutBlockBuilder in blob storage. interestingly this was no problem in the old deprecated crate (I just started to migrate).

@MindFlavor
Copy link
Contributor Author

It's my fault, I've unintentionally introduced the regression in #84.
I honestly admit I'm still fuzzy on why it happens, but, hey, you found the problem and the solution so I'm in luck 😲 !

Thank you again! 👍

@rylev rylev closed this as completed in #114 Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix request builders not being Send Azure/azure-sdk-for-rust
2 participants
@MindFlavor @extrawurst