Table API query/get all rewrite #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Nov 16, 2020
| Some(States::Init), | ||
| move |state: Option<States>| async move { | ||
| log::debug!("state == {:?}", state); | ||
| let response = match state { |
There was a problem hiding this comment.
nit: maybe match state? would make the code a little less verbose.
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
…r-rust into issue/83/table_paging
Co-authored-by: Alexei Barnes <ab@alexeibarnes.com>
Co-authored-by: Alexei Barnes <ab@alexeibarnes.com>
rylev
reviewed
Nov 23, 2020
rylev
reviewed
Nov 23, 2020
rylev
reviewed
Nov 23, 2020
| pub continuation_token: Option<ContinuationToken>, | ||
| } | ||
|
|
||
| impl<T> std::convert::TryFrom<(url::Url, &HeaderMap, &body::Bytes)> for QueryResult<T> |
There was a problem hiding this comment.
I always find conversion methods from tuples to be very confusing unless it's an extremely obvious one like (f32, f32) to Point. Is there a better way to model this?
rylev
reviewed
Nov 24, 2020
rylev
reviewed
Nov 24, 2020
| } | ||
| } | ||
|
|
||
| impl std::convert::From<(Url, ResponseFuture)> for PerformRequestResponse { |
There was a problem hiding this comment.
Not sure I like this. I think I'd prefer a PerformRequestResponse::new function. Tuples are best for data that is extremely obviously related to one another, which is not the case here. The new function will be a bit easier to understand.
rylev
reviewed
Nov 24, 2020
rylev
reviewed
Nov 24, 2020
rylev
reviewed
Nov 24, 2020
rylev
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to address #83.