update base64 to 0.21 #1194
Merged
update base64 to 0.21 #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating base64 included addressing breaking changes in the API. This update follows the crate's [RELEASE-NOTES](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md#0210) for updating our usage.
|
But do we otherwise need to? I was reading about this situation this morning, but do we actually have a need to update? Or is this just to make it easier to upgrade should we ever need to for good reason? |
|
The build is failing for this one and it has merge conflicts. |
heaths
approved these changes
Mar 14, 2023
added 2 commits
March 14, 2023 14:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating base64 included addressing breaking changes in the API. This update follows the crate's RELEASE-NOTES for updating our usage.